Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Blocks: Fix README.md Webpack import warnings during startup #29509

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Jetpack Blocks: Fix README.md Webpack import warnings during startup #29509

merged 1 commit into from
Dec 17, 2018

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Dec 17, 2018

As discovered by @sirreal (p1545067751141700-slack-jetpack-gutenberg):

When restarting Calypso, the following warnings are reported in the console that Calypso is running in:

WARNING in ./client/gutenberg/extensions/README.md 1:0
Module parse failed: Unexpected character '#' (1:0)
You may need an appropriate loader to handle this file type.
> # Gutenberg extensions
|
| This folder holds extensions for Gutenberg editor. You can either import them directly from here or build them using Calypso SDK. See [SDK documentation](../../../docs/sdk.md).
 @ ./client/gutenberg/extensions eager ^\.\/.*$ namespace object ./README.md
 @ ./client/gutenberg/extensions/presets/jetpack/editor.js
 @ ./client/gutenberg/extensions/presets/jetpack/utils/refresh-registrations.js
 @ ./client/gutenberg/editor/main.jsx

Introduced by #29435.

Changes proposed in this Pull Request

Be more explicit about the dynamic import

Testing instructions

  • Restart Calypso, and verify that these warnings are gone
  • Verify that Jetpack blocks still work in /block-editor

/cc @Automattic/team-calypso

@ockham ockham added [Type] Bug When a feature is broken and / or not performing as intended Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg labels Dec 17, 2018
@ockham ockham self-assigned this Dec 17, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/webpack-import-readme-warnings

@ockham ockham requested a review from a team December 17, 2018 18:04
sirreal
sirreal approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings are gone, working well 👍

@sirreal sirreal merged commit 9f396d9 into master Dec 17, 2018
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 17, 2018
@sirreal sirreal deleted the fix/webpack-import-readme-warnings branch December 17, 2018 18:30
blowery added a commit that referenced this pull request Dec 18, 2018
@blowery
Merge remote-tracking branch 'origin/master' into feature/color-refre…
c983169 
…sh-2019

* origin/master:
  change "expert" to "support" in page route and title (#29459)
  Add note to concierge upsell page about sessions only being offered in English. (#29461)
  Jetpack Blocks: Fix webpack warnings due to dynamic import (#29509)
  Gutenberg: Reset core resolvers on site change (#29445)
  Signup: Remove Masterbar from Signup (#28886)
  Fix missing bumpStat call (#29504)
  Gutenberg Jetpack Preset: Generate imports dynamically from index.json (#29435)
  Fix the clean:public script to do a better job cleaning public/ folder (#29354)
  Tiled gallery: Add alignWide support (#29493)
  Tiled Gallery: Add noResize to block save (#29496)
  Show G Suite user fields by default (#29458)
  ColorThemes: Add GA and bumpStat events for scheme picking (#29413)
  Remove legacy mock for extensions reducer (#29397)
  Antispam promo card: tweak copy to make it clearer (#29440)
  prevent 0 as street number for ebanx checkouts (#29487)
  Gutenberg: Update Related Posts to use the posts endpoint (#29439)
  remove override on payment methods name in India (#29406)
  Add a space to separate "the" from the holiday name placeholder. (#29479)
  Revert "Migrate my-sites/sharing to webpack css pipeline (#28607)" (#29463)
  Gutenpack Subscription Block (Take two) (#28887)
@ockham
Copy link
Contributor Author

ockham commented Dec 18, 2018

Thanks @sirreal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirreal sirreal sirreal approved these changes

Assignees

@ockham ockham

Labels
[Goal] Gutenberg Working towards full integration with Gutenberg Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ockham @matticbot @sirreal