Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorThemes: Send analytics when changing themes #29413

Merged
merged 1 commit into from
Dec 17, 2018
Merged

ColorThemes: Send analytics when changing themes #29413

merged 1 commit into from
Dec 17, 2018

Conversation

blowery
Copy link
Contributor

@blowery blowery commented Dec 13, 2018

One for set, one for save.

Testing Instructions:

  • Boot up calypso
  • Go to /me/account-settings
  • Change themes. You should see a tracks event, a GA event, and a bumpStat fire
  • Save your changes. You should see the same triad of events, but with "Save" in the name instead of "set"

@blowery blowery added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Color Schemes labels Dec 13, 2018
@blowery blowery self-assigned this Dec 13, 2018
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/tracks-for-color-themes

@blowery blowery requested a review from a team December 13, 2018 16:50
@jsnajdr
Copy link
Member

jsnajdr commented Dec 14, 2018

I never see the "saved" events being fired. That's because the ColorSchemePicker is always rendered with temporarySelection set to true. The false branch is unused code.

What I see instead are preexisting calypso_color_schemes_select and calypso_color_schemes_save events fired from the parent component (Account form) here and here.

Do we want to remove the existing events? Or to continue using them and just add the bumpStat and GA destinations?

There's also some naming inconsistency: theme vs scheme vs schemes. Which one do we want to unify on?

@jsnajdr jsnajdr added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 14, 2018
@blowery
Copy link
Contributor Author

blowery commented Dec 14, 2018

What I see instead are preexisting calypso_color_schemes_select and calypso_color_schemes_save events fired from the parent component (Account form) here and here.

Sigh. I totally missed that.

Do we want to remove the existing events? Or to continue using them and just add the bumpStat and GA destinations?

Just add bumpStat and GA events to the parent, I guess.

@blowery blowery force-pushed the add/tracks-for-color-themes branch from e638295 to 2d82c5e Compare December 14, 2018 12:28
@blowery
ColorThemes: Add GA and bumpStat events for scheme picking
cc69419 
Emit a GA event when selecting or saving a new scheme.
Only emit a bumpStat when we save the theme.
@blowery blowery force-pushed the add/tracks-for-color-themes branch from 2d82c5e to cc69419 Compare December 14, 2018 12:30
@blowery
Copy link
Contributor Author

blowery commented Dec 14, 2018

@jsnajdr revised this to piggyback on the existing place where we emit stats. It's failing lint because me/main is ancient and in need of a good scrub.

jsnajdr
jsnajdr approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks good 👍

@blowery blowery merged commit 020f27c into master Dec 17, 2018
@blowery blowery deleted the add/tracks-for-color-themes branch December 17, 2018 13:59
@blowery blowery mentioned this pull request Dec 17, 2018
Merged
blowery added a commit that referenced this pull request Dec 18, 2018
@blowery
Merge remote-tracking branch 'origin/master' into feature/color-refre…
c983169 
…sh-2019

* origin/master:
  change "expert" to "support" in page route and title (#29459)
  Add note to concierge upsell page about sessions only being offered in English. (#29461)
  Jetpack Blocks: Fix webpack warnings due to dynamic import (#29509)
  Gutenberg: Reset core resolvers on site change (#29445)
  Signup: Remove Masterbar from Signup (#28886)
  Fix missing bumpStat call (#29504)
  Gutenberg Jetpack Preset: Generate imports dynamically from index.json (#29435)
  Fix the clean:public script to do a better job cleaning public/ folder (#29354)
  Tiled gallery: Add alignWide support (#29493)
  Tiled Gallery: Add noResize to block save (#29496)
  Show G Suite user fields by default (#29458)
  ColorThemes: Add GA and bumpStat events for scheme picking (#29413)
  Remove legacy mock for extensions reducer (#29397)
  Antispam promo card: tweak copy to make it clearer (#29440)
  prevent 0 as street number for ebanx checkouts (#29487)
  Gutenberg: Update Related Posts to use the posts endpoint (#29439)
  remove override on payment methods name in India (#29406)
  Add a space to separate "the" from the holiday name placeholder. (#29479)
  Revert "Migrate my-sites/sharing to webpack css pipeline (#28607)" (#29463)
  Gutenpack Subscription Block (Take two) (#28887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnajdr jsnajdr jsnajdr approved these changes

Assignees

@blowery blowery

Labels
Color Schemes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blowery @matticbot @jsnajdr