Gutenpack Subscription Block (Take two) #28887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gititon
added
Jetpack
[Status] In Progress
[Goal] Gutenberg
enejb
reviewed
Nov 29, 2018
enejb
reviewed
Nov 29, 2018
enejb
reviewed
Nov 29, 2018
enejb
reviewed
Nov 29, 2018
gititon
added
[Status] Needs Review
aldavigdis
added
the
[Feature] Subscriptions
enejb
reviewed
Nov 30, 2018
gititon
force-pushed
the
subscriptions-block-two
branch
from
1a93993 to
4357945
Compare
enejb
reviewed
Dec 13, 2018
enejb
reviewed
Dec 13, 2018
simison
reviewed
Dec 14, 2018
simison
reviewed
Dec 14, 2018
simison
reviewed
Dec 14, 2018
…g attributes to use camelcase for consistency
simison
reviewed
Dec 14, 2018
simison
reviewed
Dec 14, 2018
simison
reviewed
Dec 14, 2018
simison
reviewed
Dec 14, 2018
…ndling for count api response, fixed single subscriber string
…moved unnecessary pragma
lezama
reviewed
Dec 14, 2018
lezama
reviewed
Dec 14, 2018
lezama
reviewed
Dec 14, 2018
| const { showSubscribersTotal } = attributes; | ||
| return ( | ||
| <RawHTML | ||
| >{ `[jetpack_subscription_form show_subscribers_total="${ showSubscribersTotal }" show_only_email_and_button="true"]` }</RawHTML> |
There was a problem hiding this comment.
Suggested change
| >{ `[jetpack_subscription_form show_subscribers_total="${ showSubscribersTotal }" show_only_email_and_button="true"]` }</RawHTML> | |
| >{ `[jetpack_subscription_form show_subscribers_total="${ showSubscribersTotal }" show_title="false"]` }</RawHTML> |
I think we should go this way with the format of the shortcode, but let's change it on a following iteration
lezama
reviewed
Dec 14, 2018
lezama
reviewed
Dec 14, 2018
lezama
reviewed
Dec 14, 2018
lezama
reviewed
Dec 14, 2018
lezama
approved these changes
Dec 14, 2018
matticbot
removed
the
[Status] Needs Review
blowery
added a commit
that referenced
this pull request
Dec 18, 2018
…sh-2019 * origin/master: change "expert" to "support" in page route and title (#29459) Add note to concierge upsell page about sessions only being offered in English. (#29461) Jetpack Blocks: Fix webpack warnings due to dynamic import (#29509) Gutenberg: Reset core resolvers on site change (#29445) Signup: Remove Masterbar from Signup (#28886) Fix missing bumpStat call (#29504) Gutenberg Jetpack Preset: Generate imports dynamically from index.json (#29435) Fix the clean:public script to do a better job cleaning public/ folder (#29354) Tiled gallery: Add alignWide support (#29493) Tiled Gallery: Add noResize to block save (#29496) Show G Suite user fields by default (#29458) ColorThemes: Add GA and bumpStat events for scheme picking (#29413) Remove legacy mock for extensions reducer (#29397) Antispam promo card: tweak copy to make it clearer (#29440) prevent 0 as street number for ebanx checkouts (#29487) Gutenberg: Update Related Posts to use the posts endpoint (#29439) remove override on payment methods name in India (#29406) Add a space to separate "the" from the holiday name placeholder. (#29479) Revert "Migrate my-sites/sharing to webpack css pipeline (#28607)" (#29463) Gutenpack Subscription Block (Take two) (#28887)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This pull request adds the Gutenberg Subscription block.
The Subscription block invites visitors to sign up to be notified when there are new posts on a site.
When the block has focus in the editor, editors can toggle whether to show the number of subscribers in the block. When it doesn't have focus, editors will see the number of subscribers if they toggled that on.
Testing instructions
Note that the block still is going to receive some CSS ❤️(cc @MichaelArestad) , so please focus on testing its functionality for now.
Checkout this Calypso branch and the corresponding Jetpack branch, Gutenpack Subscription Block jetpack#10564.
Run the command to build the Subscription block from your wp-calypso repo directory:
Connect Jetpack if it isn't connected
Create a new post and add the Jetpack Subscription Block.
Toggle the "show number of subscribers". Confirm that you see the number of subscribers when the block loses focus.
Publish the post. Confirm that you see it on the frontend.
Subscribe by using the block with a user or two (they will have to be a connected Jetpack user)
Confirm that you see the number of subscribed users on the frontend (when the toggle was enabled for the block in the editor) and the editor when the block doesn't have focus.