Tiled Gallery: Add noResize to block save #29496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The block save method should not depend on the browser. It should not create ResizeObservers and should be completely deterministic. This helps ensure that the block can be saved and parsed consistently so that it is not invalidated by the parser.
sirreal
added
[Status] Needs Review
|
I'm not in love with Ideally, we'd like to separate out structural layout (React rendering) from any resizing logic necessary in JavaScript. |
simison
reviewed
Dec 17, 2018
| if ( width && width !== this.state.width ) { | ||
| this.setWidth( width ); | ||
| handleResize = this.props.noResize | ||
| ? () => {} |
There was a problem hiding this comment.
I take that this ternary is just an optimization because we already have if ( ! this.props.noResize ) in componentDidMount ?
There was a problem hiding this comment.
At this point, it's redundant as you note. I expect we may start to call resize on mount to get initial sizes set up. This is also complete, noResize really will not resize.
simison
approved these changes
Dec 17, 2018
sirreal
added
[Status] Ready to Merge
and removed
[Status] Needs Review
blowery
added a commit
that referenced
this pull request
Dec 18, 2018
…sh-2019 * origin/master: change "expert" to "support" in page route and title (#29459) Add note to concierge upsell page about sessions only being offered in English. (#29461) Jetpack Blocks: Fix webpack warnings due to dynamic import (#29509) Gutenberg: Reset core resolvers on site change (#29445) Signup: Remove Masterbar from Signup (#28886) Fix missing bumpStat call (#29504) Gutenberg Jetpack Preset: Generate imports dynamically from index.json (#29435) Fix the clean:public script to do a better job cleaning public/ folder (#29354) Tiled gallery: Add alignWide support (#29493) Tiled Gallery: Add noResize to block save (#29496) Show G Suite user fields by default (#29458) ColorThemes: Add GA and bumpStat events for scheme picking (#29413) Remove legacy mock for extensions reducer (#29397) Antispam promo card: tweak copy to make it clearer (#29440) prevent 0 as street number for ebanx checkouts (#29487) Gutenberg: Update Related Posts to use the posts endpoint (#29439) remove override on payment methods name in India (#29406) Add a space to separate "the" from the holiday name placeholder. (#29479) Revert "Migrate my-sites/sharing to webpack css pipeline (#28607)" (#29463) Gutenpack Subscription Block (Take two) (#28887)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block save method should not depend on the browser. It should not
create ResizeObservers and should be completely deterministic.
This helps ensure that the block can be saved and parsed consistently so
that it is not invalidated by the parser.
Bite sized PR from #29465
Testing