Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: tweak copy in anti-spam promo card to make it clearer #29440

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

keoshi
Copy link
Contributor

@keoshi keoshi commented Dec 14, 2018

Changes proposed in this Pull Request

  • Tweak copy in anti-spam promo card in Settings to make it clearer.

Before

image

After

image

Testing instructions

  • Fire up this branch.
  • Take a look at /settings/security/ with a Jetpack site on the free plan.
  • Make sure the copy looks good.

Fixes #28739

@keoshi keoshi added [Feature] Site Settings All other general site settings. Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Dec 14, 2018
@keoshi keoshi self-assigned this Dec 14, 2018
@matticbot
Copy link
Contributor

@keoshi keoshi requested review from a team December 14, 2018 15:18
@MichaelArestad MichaelArestad added the [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR label Dec 14, 2018
@MichaelArestad
Copy link
Contributor

MichaelArestad commented Dec 14, 2018

Ah. Yeah. Nobody wants to tweeze spam anyway. I dig!

@MichaelArestad MichaelArestad removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 14, 2018
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@keoshi keoshi merged commit 769b775 into master Dec 17, 2018
@keoshi keoshi deleted the update/antispam-promo-card-copy branch December 17, 2018 10:18
@michelleweber
Copy link

Dig it.

@keoshi keoshi removed the [Status] Needs Copy Review Add this when you'd like to get a review / feedback from the Editorial team on your PR label Dec 17, 2018
blowery added a commit that referenced this pull request Dec 18, 2018
…sh-2019

* origin/master:
  change "expert" to "support" in page route and title (#29459)
  Add note to concierge upsell page about sessions only being offered in English. (#29461)
  Jetpack Blocks: Fix webpack warnings due to dynamic import (#29509)
  Gutenberg: Reset core resolvers on site change (#29445)
  Signup: Remove Masterbar from Signup (#28886)
  Fix missing bumpStat call (#29504)
  Gutenberg Jetpack Preset: Generate imports dynamically from index.json (#29435)
  Fix the clean:public script to do a better job cleaning public/ folder (#29354)
  Tiled gallery: Add alignWide support (#29493)
  Tiled Gallery: Add noResize to block save (#29496)
  Show G Suite user fields by default (#29458)
  ColorThemes: Add GA and bumpStat events for scheme picking (#29413)
  Remove legacy mock for extensions reducer (#29397)
  Antispam promo card: tweak copy to make it clearer (#29440)
  prevent 0 as street number for ebanx checkouts (#29487)
  Gutenberg: Update Related Posts to use the posts endpoint (#29439)
  remove override on payment methods name in India (#29406)
  Add a space to separate "the" from the holiday name placeholder. (#29479)
  Revert "Migrate my-sites/sharing to webpack css pipeline (#28607)" (#29463)
  Gutenpack Subscription Block (Take two) (#28887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Settings All other general site settings. Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants