[WIP] GraalVM JDK 21 #669

geofjamg · 2023-10-27T10:18:10Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

JDK version update

What is the current behavior?

In order to use '--pgo-instrument -H:+ProfilingEnableProfileDumpHooks' to instrument for PGO a shared library we need to upgrade to JDK 21. This is not supported with JDK 17.
But there is an issue in JDK 21 that does not allow to use native image with the class path oracle/graal#7712. So we need to wait for a fix or a workaround.
Another issue that have to be solved for upgrading to JDK21: oracle/graal#7759

24/08/04 Still same error with JDK22

Error: Expected Object but got Word for call argument in com.powsybl.python.network.NetworkCFunctions.setWorkingVariant(NetworkCFunctions.java:376). One possible cause for this error is when word values are passed into lambdas as parameters or from variables in an enclosing scope, which is not supported, but can be solved by instead using explicit classes (including anonymous classes).

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

The Breaking Change or Deprecated label has been added
The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)

Other information:

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

EtienneLt · 2023-11-02T12:23:14Z

java/pom.xml

@@ -61,9 +61,9 @@
    <version>1.1.0-SNAPSHOT</version>

    <properties>
-        <java.version>17</java.version>
+        <java.version>21</java.version>


no problem with maven version ?

We will revert this to 17 in this pr to keep java 17 source compatibility, even using jdk 21

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

# Conflicts: # README.md

# Conflicts: # cpp/CMakeLists.txt

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

* add parameter : edge_info_displayed --------- Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>

* add Sld parameters in doc --------- Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>

* Upgrade to PowSyBl 2024.1.2 --------- Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>

--------- Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com> Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>

Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com> Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>

Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

…parameters list, is evaluated at declaration and can trigger a call before proper pypowsybl init. (#804) Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com> Co-authored-by: HugoKulesza <94374655+HugoKulesza@users.noreply.github.com>

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it> Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com> Co-authored-by: HugoKulesza <94374655+HugoKulesza@users.noreply.github.com>

--------- Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>

…rameter (#806) Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com> Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

# Conflicts: # cpp/powsybl-cpp/CMakeLists.txt

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

# Conflicts: # cpp/powsybl-cpp/CMakeLists.txt # java/src/main/java/com/powsybl/python/network/NetworkCFunctions.java

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

geofjamg added 4 commits October 27, 2023 12:12

GraalVM JDK 21

248d927

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

9fda9c1

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

0adb2ca

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

139e2de

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

EtienneLt added the do not merge label Oct 30, 2023

geofjamg added 2 commits November 1, 2023 14:24

Wip

65bba7f

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

970136d

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

EtienneLt reviewed Nov 2, 2023

View reviewed changes

geofjamg added 4 commits November 2, 2023 21:11

Wip

6f80e05

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

9966bf2

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

7469bf7

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Wip

1dd696d

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

EtienneLt assigned geofjamg Nov 8, 2023

geofjamg added 5 commits February 22, 2024 09:13

Merge branch 'main' into graalvm_jdk21

11c7d1a

# Conflicts: # README.md

Merge branch 'main' into graalvm_jdk21

46f4ec9

Merge branch 'main' into graalvm_jdk21

d32afa3

# Conflicts: # cpp/CMakeLists.txt

Merge

2eb0e2a

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Fix

fcf2181

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

geofjamg changed the title ~~[WIP] GraalVM JDK 21~~ [WIP] GraalVM JDK 22 Aug 24, 2024

unetablettedechocolat and others added 11 commits August 24, 2024 17:20

Edge info displayed (#773)

947af39

* add parameter : edge_info_displayed --------- Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>

remove deprecated attributes in network modification functions (#732)

d605170

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>

add Sld parameters in doc (#775)

6c2002a

* add Sld parameters in doc --------- Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>

Upgrade to PowSyBl 2024.1.2 (#783)

ba28c19

* Upgrade to PowSyBl 2024.1.2 --------- Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Clean doc setup (#784)

6f652f9

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

CI should fail in case of doc generation warnings (#787)

ca23cfd

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Remove debug prints (#788)

260fc95

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Add support of dc_power_factor Load Flow Parameter (#756)

3901818

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>

Fix CI manylinux (#794)

432b597

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>

Add DanglingLine boundary side P, Q, Vmag, Vangle (#792)

c326d29

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>

adding documentation for reduce function (#791)

6cf3c61

--------- Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>

unetablettedechocolat and others added 22 commits August 24, 2024 17:20

Add get_matrix_multi_substation_single_line_diagram (#781)

293d066

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com> Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>

Bump to v1.6.0

212530c

Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>

Bump to v1.7.0-SNAPSHOT

462e81a

Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>

Adding current feeder info parameter for SLD (#785)

9548e88

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com> Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com>

Fix CI : regain compatibility with node16 for the CI (#798)

c066f58

Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>

Fix Windows CI : set matplotlib to 3.9.0 for python > 3.8 (#801)

597cddf

Signed-off-by: Hugo KULESZA <hugo.kulesza@rte-france.com>

Fix MSVC runtime binaries incompatibility issues (#803)

f25270c

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

Fix multi substation sld svg (#797)

146e4e1

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it> Co-authored-by: Sophie Frasnedo <93923177+So-Fras@users.noreply.github.com> Co-authored-by: HugoKulesza <94374655+HugoKulesza@users.noreply.github.com>

add documentation for hvdc lines (#805)

ece090e

--------- Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>

Rename enum related to ampl logging (#812)

076162e

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>

Make pairing key of dangling lines updatable (#811)

493dbdc

Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>

Display units feeder info (#799)

eb1661e

Signed-off-by: Tiphaine Mouminous <tiphaine.mouminous_externe@rte-france.com>

Allows empty strings in the multi-substation SLD functions' matrix pa…

e3fd8f2

…rameter (#806) Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>

Add initial voltage plan parameter for short-circuit analysis (#809)

21c71f8

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com> Signed-off-by: Coline PILOQUET <coline.piloquet@rte-france.com>

Add attribute "paired" for dangling lines (#815)

f822389

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>

Update

0e337eb

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Merge branch 'main' into graalvm_jdk21

9ea80ab

Wip

5b6be19

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@gmail.com>

Merge branch 'main' into graalvm_jdk21

114999f

Merge remote-tracking branch 'origin/graalvm_jdk21' into graalvm_jdk21

980ca17

# Conflicts: # cpp/powsybl-cpp/CMakeLists.txt

Wip

f2399dd

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

geofjamg changed the title ~~[WIP] GraalVM JDK 22~~ [WIP] GraalVM JDK 21 Sep 10, 2024

geofjamg added 4 commits September 10, 2024 14:57

Wip

29887a0

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Wip

603aeef

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Merge branch 'main' into graalvm_jdk21

13bbbb9

# Conflicts: # cpp/powsybl-cpp/CMakeLists.txt # java/src/main/java/com/powsybl/python/network/NetworkCFunctions.java

Fix

30a396c

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] GraalVM JDK 21 #669

[WIP] GraalVM JDK 21 #669

geofjamg commented Oct 27, 2023 •

edited

Loading

EtienneLt Nov 2, 2023

geofjamg Nov 2, 2023

[WIP] GraalVM JDK 21 #669

Are you sure you want to change the base?

[WIP] GraalVM JDK 21 #669

Conversation

geofjamg commented Oct 27, 2023 • edited Loading

EtienneLt Nov 2, 2023

Choose a reason for hiding this comment

geofjamg Nov 2, 2023

Choose a reason for hiding this comment

geofjamg commented Oct 27, 2023 •

edited

Loading