Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename AMPL log related enum #812

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Rename AMPL log related enum #812

merged 1 commit into from
Jul 30, 2024

Conversation

obrix
Copy link
Member

@obrix obrix commented Jul 29, 2024

Rename enum related to ampl logging, they are too common and some collision issue arise when reusing cpp part in powsybl julia.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

…lision issue arise when reusing cpp part in powsybl julia.

Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
@obrix obrix requested a review from HugoKulesza July 29, 2024 08:35
@HugoKulesza HugoKulesza merged commit 2b7f0c7 into main Jul 30, 2024
6 checks passed
@HugoKulesza HugoKulesza deleted the ampl_log_enum_fix branch July 30, 2024 11:43
geofjamg pushed a commit that referenced this pull request Aug 24, 2024
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
geofjamg pushed a commit that referenced this pull request Aug 27, 2024
Signed-off-by: Bertrand Rix <bertrand.rix@artelys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants