Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of dc_power_factor Load Flow Parameter #756

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Conversation

jeandemanged
Copy link
Member

@jeandemanged jeandemanged commented Jun 1, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

PyPowSyBl does not have powsybl-core's dcPowerFactor load flow parameter (powsybl/powsybl-core#2473)

What is the new behavior (if this is a feature change)?
Added dc_power_factor load flow parameter

Does this PR introduce a breaking change or deprecate an API?

  • No

Other information:

Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged
Copy link
Member Author

@EtienneLt @geofjamg @obrix help :(

this sounded like an easy feature, but I cannot understand what is going on in load flow validation, why/where a zero power factor shows up and causes an exception ... ( while LoadFlow and SecurityAnalysis are ok ...)

=========================== short test summary info ============================
FAILED test_loadflow.py::test_validation - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_twt_validation - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_all - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_parameters_not_valid - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_parameters_valid - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_wrong_regulated_bus_id - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0

@jeandemanged jeandemanged changed the title Adde support of dc_power_factor LoadFlow Parameter Add support of dc_power_factor LoadFlow Parameter Jun 7, 2024
@jeandemanged
Copy link
Member Author

@EtienneLt @geofjamg @obrix help :(

this sounded like an easy feature, but I cannot understand what is going on in load flow validation, why/where a zero power factor shows up and causes an exception ... ( while LoadFlow and SecurityAnalysis are ok ...)

=========================== short test summary info ============================
FAILED test_loadflow.py::test_validation - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_twt_validation - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_all - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_parameters_not_valid - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_validation_parameters_valid - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0
FAILED test_loadflow.py::test_wrong_regulated_bus_id - pypowsybl._pypowsybl.PyPowsyblError: Invalid DC power factor: 0.0

there was a bug in LoadFlowValidationParameters code, fix: 13e6936

@jeandemanged jeandemanged changed the title Add support of dc_power_factor LoadFlow Parameter Add support of dc_power_factor Load Flow Parameter Jun 29, 2024
@geofjamg geofjamg merged commit 047cd71 into main Jul 1, 2024
6 checks passed
@geofjamg geofjamg deleted the lf-params-dc-pf branch July 1, 2024 08:46
geofjamg pushed a commit that referenced this pull request Aug 24, 2024
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
geofjamg pushed a commit that referenced this pull request Aug 27, 2024
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants