Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should fail in case of doc generation warnings #787

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

geofjamg
Copy link
Member

@geofjamg geofjamg commented Jun 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Quallity improvement

What is the current behavior?

CI succeed even in case of doc generation warnings

What is the new behavior (if this is a feature change)?
CI fails in case of doc generation warnings

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
@geofjamg geofjamg requested a review from EtienneLt June 26, 2024 13:26
@EtienneLt EtienneLt merged commit bb6e3e6 into main Jun 26, 2024
6 checks passed
@EtienneLt EtienneLt deleted the doc_warning_failure branch June 26, 2024 13:37
geofjamg added a commit that referenced this pull request Aug 24, 2024
Signed-off-by: Geoffroy Jamgotchian <geoffroy.jamgotchian@rte-france.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants