Add event stats output to the operator logs for Ansible based-operators. #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
asmacdo
approved these changes
Feb 19, 2020
camilamacedo86
commented
Feb 20, 2020
camilamacedo86
commented
Feb 20, 2020
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
removed
the
do-not-merge/hold
jmrodri
requested changes
Feb 21, 2020
Comment on lines
+258
to
+263
| func printEventStats(statusEvent eventapi.StatusJobEvent) { | ||
| fmt.Printf("\n--------------------------- Ansible Task Status Event StdOut -----------------\n") | ||
| fmt.Println(statusEvent.StdOut) | ||
| fmt.Printf("\n-------------------------------------------------------------------------------\n") | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe I'm missing something but why do we use fmt.Printf here but logger. in other places.
There was a problem hiding this comment.
To print the data formatted such as we do here: #2321. It has an image which shows the output as well.
There was a problem hiding this comment.
Yeah, if you put the ansible stdout through the logger it gets mangled completely since it is JSON serialized
fabianvf
approved these changes
Feb 21, 2020
jmrodri
approved these changes
Feb 21, 2020
camilamacedo86
added a commit
that referenced
this pull request
Feb 25, 2020
…le logs on it (#2589) **Description of the change:** - Add full Ansible result output to the operator logs for Ansible based-operators configurable by EnvVar. **Motivation for the change:** Allow users to have the same full information that can be obtained until the version 0.15.x with the Ansible sidecar container in the operator logs. Note that we deprecated the inotify-tools and we will no longer scaffold the sidecar container. See #2586. Also, we have been improving the operator logs in order to attend all needs. See: #2580 and #2321.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add event stats output to the operator logs for Ansible based-operators.
Motivation
Allow we remove the ansible container ( Related to #2007 )