-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Improve log format of Ansible-based Operators #2321
Merged
camilamacedo86
merged 2 commits into
operator-framework:master
from
camilamacedo86:log-format
Dec 13, 2019
Merged
feat:Improve log format of Ansible-based Operators #2321
camilamacedo86
merged 2 commits into
operator-framework:master
from
camilamacedo86:log-format
Dec 13, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmrodri
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
New changes are detected. LGTM label has been removed. |
asmacdo
approved these changes
Dec 13, 2019
awesome! |
This was referenced Feb 21, 2020
camilamacedo86
added a commit
that referenced
this pull request
Feb 25, 2020
…le logs on it (#2589) **Description of the change:** - Add full Ansible result output to the operator logs for Ansible based-operators configurable by EnvVar. **Motivation for the change:** Allow users to have the same full information that can be obtained until the version 0.15.x with the Ansible sidecar container in the operator logs. Note that we deprecated the inotify-tools and we will no longer scaffold the sidecar container. See #2586. Also, we have been improving the operator logs in order to attend all needs. See: #2580 and #2321.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
operator-sdk up local
and check the logsCloses #2244
Local test with the scenario of #2244