Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[operator] ao-logs going to go away - find replacement #2611

Closed
jmazzitelli opened this issue Apr 3, 2020 · 6 comments · Fixed by #2644 or kiali/kiali-operator#90
Closed

[operator] ao-logs going to go away - find replacement #2611

jmazzitelli opened this issue Apr 3, 2020 · 6 comments · Fixed by #2644 or kiali/kiali-operator#90
Assignees
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.

Comments

@jmazzitelli
Copy link
Collaborator

the ansible operator uses the ao-logs script to log the ansible messages in the ansible container.

However, when you start the operator now, the first line that spits out is:

WARN: This script is deprecated and will soon be removed
Setting up watches.  Beware: since -r was given, this may take a while!
Watches established.

So we need to find out what the alternative is and switch to that.

@jmazzitelli jmazzitelli added the enhancement This is the preferred way to describe new end-to-end features. label Apr 3, 2020
@jmazzitelli
Copy link
Collaborator Author

jmazzitelli commented Apr 3, 2020

from slack:

Task stdout is printed to the operator log now, and if you
set the ANSIBLE_DEBUG_LOGS environment variable
on your operator deployment it will print out the full
output at the end of the run as well

See: https://github.com/operator-framework/operator-sdk/blob/master/doc/ansible/dev/developer_guide.md#viewing-the-ansible-logs

@jmazzitelli
Copy link
Collaborator Author

jmazzitelli commented Apr 10, 2020

The way the ansible operator base image logs its output changed. See:

operator-framework/operator-sdk#2321 (went in 0.14.0)
operator-framework/operator-sdk#2580 (went in 0.16.0)
operator-framework/operator-sdk#2589 (went in 0.16.0)

This is because the ao-logs are not available in RHEL8/UBI8 - see operator-framework/operator-sdk#2007

The ao-logs script is still available in 0.16.0 but we don't need it with the way 0.16.0 outputs the ansible logs now. The currently productized ansible base images are well-behind 0.16.0, though. We can move ahead with the implementation of this in the community builds, but not for the productized builds because we need 0.16.0 in order to replace the log output we lose when not using ao-logs.

As of this writing:
The latest openshift-ose-ansible-operator:v4.2.x is based on 0.10.0.
The latest openshift-ose-ansible-operator:v4.3.x is based on 0.12.0 (registry-proxy.engineering.redhat.com/rh-osbs/openshift-ose-ansible-operator:v4.3.10-202003311428)

@jmazzitelli
Copy link
Collaborator Author

PR #2644 is ready but we will need a second PR that removes the ao-logs container from the kiali-ossm metadata - this can only happen when a productized version of the ansible base image is up to at least 0.16.0.

@jmazzitelli
Copy link
Collaborator Author

Re-opening because we need to do something similar for kiali-ossm metadata.

@jmazzitelli jmazzitelli reopened this Apr 14, 2020
@jmazzitelli
Copy link
Collaborator Author

The latest 4.4 also is not at the version we need as of right now. See:

$ docker run --rm -i -t registry-proxy.engineering.redhat.com/rh-osbs/openshift-ose-ansible-operator:v4.4.0-202004261927
...
{"level":"info","ts":1589532571.8891735,"logger":"cmd","msg":"Version of operator-sdk: v0.12.0+git"}

@jmazzitelli jmazzitelli added the waiting external It requires additional info to progress. For example, it can require a fix in other project. label May 15, 2020
@jmazzitelli jmazzitelli self-assigned this May 15, 2020
@jmazzitelli
Copy link
Collaborator Author

Base image 4.5 is now at 0.16.0 which provides the alternative to the ao-logs. We can implement this now.

@jmazzitelli jmazzitelli added backlog Triaged Issue added to backlog team/saturn and removed waiting external It requires additional info to progress. For example, it can require a fix in other project. labels Jul 20, 2020
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue Jul 21, 2020
this also fixes some other metadata for the next release based on the new sdk
jmazzitelli added a commit to kiali/kiali-operator that referenced this issue Jul 21, 2020
* remove ao-logs - this fixes: kiali/kiali#2611
this also fixes some other metadata for the next release based on the new sdk

* convert to using the new k8s_info. fixes: kiali/kiali#2073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Triaged Issue added to backlog enhancement This is the preferred way to describe new end-to-end features.
Projects
None yet
1 participant