Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more further reading #2637

Merged
merged 1 commit into from
Aug 2, 2023
Merged

add more further reading #2637

merged 1 commit into from
Aug 2, 2023

Conversation

pld
Copy link
Member

@pld pld commented Aug 2, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #2637 (b028f81) into main (d84c2c8) will decrease coverage by 1.2%.
Report is 35 commits behind head on main.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2637     +/-   ##
=========================================
- Coverage     65.4%   64.3%   -1.2%     
+ Complexity    1101      26   -1075     
=========================================
  Files          213       4    -209     
  Lines         9385     227   -9158     
  Branches      1866      32   -1834     
=========================================
- Hits          6140     146   -5994     
+ Misses        2047      65   -1982     
+ Partials      1198      16   -1182     
Flag Coverage Δ
engine ?
geowidget 64.3% <37.5%> (+1.0%) ⬆️
quest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ster/fhircore/geowidget/KujakuFhirCoreConverter.kt 90.0% <ø> (ø)
...er/fhircore/geowidget/screens/GeoWidgetFragment.kt 34.2% <0.0%> (+2.1%) ⬆️
...r/fhircore/geowidget/screens/GeoWidgetViewModel.kt 86.3% <100.0%> (ø)
...e/geowidget/util/extensions/GeoWidgetExtensions.kt 97.7% <100.0%> (+0.1%) ⬆️

... and 207 files with indirect coverage changes

@pld pld merged commit e804033 into main Aug 2, 2023
@pld pld deleted the pld-add-resource-docs branch August 2, 2023 17:44
AbdulWahabMemon added a commit that referenced this pull request Aug 7, 2023
* main:
  Make SideMenu items scrollable (#2645)
  Add progress indicator for report generation (#2635)
  CHT measure report result screen (#2624)
  Provide missing QuestionnaireResponse in bundle param for FhirCarePlanGenerator#conditionallyUpdateResourceStatus (#2643)
  Fix resource closure failure after server sync (#2639)
  Fix build
  add more further reading (#2637)
  Refactor questionnaire implementation (#2622)
  Fix Unit Tests + Build 💚
  Fix Unit Tests ✅
  Clean up
  Fix Unit tests ✅
  Updating the login flow to save multiple practitioner details (#2623)
  Disable Dialog Dismiss Incase of Initial Sync Errors (#2608)
  Add the new ecbis production flavor
  Performance tests for loading register data (#2592)
  Fix back navigation for date selection page (#2628)
  Create github release file (#2611)
  Add form authoring consideration documentation (#2618)
qiarie pushed a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant