Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress indicator for report generation #2635

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Aug 2, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2634

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #2635 (56d10eb) into main (ad3a737) will increase coverage by 0.4%.
Report is 4 commits behind head on main.
The diff coverage is 61.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2635     +/-   ##
=========================================
+ Coverage     64.5%   65.0%   +0.4%     
- Complexity    1075    1078      +3     
=========================================
  Files          218     218             
  Lines         9635    9660     +25     
  Branches      1897    1900      +3     
=========================================
+ Hits          6218    6282     +64     
+ Misses        2234    2170     -64     
- Partials      1183    1208     +25     
Flag Coverage Δ
engine 72.6% <60.0%> (-0.1%) ⬇️
geowidget 64.3% <ø> (ø)
quest 59.8% <61.2%> (+0.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...quest/ui/report/measure/MeasureReportMainScreen.kt 0.0% <0.0%> (ø)
...re/components/MeasureReportPopulationResultView.kt 76.1% <50.0%> (+0.5%) ⬆️
.../report/measure/screens/MeasureReportListScreen.kt 53.8% <59.0%> (+53.8%) ⬆️
...er/fhircore/engine/data/local/DefaultRepository.kt 69.0% <60.0%> (-0.3%) ⬇️
...e/quest/ui/questionnaire/QuestionnaireViewModel.kt 73.1% <100.0%> (ø)
...re/components/MeasureReportIndividualResultView.kt 75.0% <100.0%> (+1.3%) ⬆️
...eport/measure/screens/MeasureReportResultScreen.kt 66.6% <100.0%> (+66.6%) ⬆️

... and 3 files with indirect coverage changes

@Rkareko Rkareko requested a review from ellykits August 7, 2023 06:06
@Rkareko Rkareko marked this pull request as ready for review August 7, 2023 06:06
@Rkareko Rkareko merged commit 9b2229b into main Aug 7, 2023
@Rkareko Rkareko deleted the 2634-report-gen-progress branch August 7, 2023 07:12
AbdulWahabMemon added a commit that referenced this pull request Aug 7, 2023
* main:
  Make SideMenu items scrollable (#2645)
  Add progress indicator for report generation (#2635)
  CHT measure report result screen (#2624)
  Provide missing QuestionnaireResponse in bundle param for FhirCarePlanGenerator#conditionallyUpdateResourceStatus (#2643)
  Fix resource closure failure after server sync (#2639)
  Fix build
  add more further reading (#2637)
  Refactor questionnaire implementation (#2622)
  Fix Unit Tests + Build 💚
  Fix Unit Tests ✅
  Clean up
  Fix Unit tests ✅
  Updating the login flow to save multiple practitioner details (#2623)
  Disable Dialog Dismiss Incase of Initial Sync Errors (#2608)
  Add the new ecbis production flavor
  Performance tests for loading register data (#2592)
  Fix back navigation for date selection page (#2628)
  Create github release file (#2611)
  Add form authoring consideration documentation (#2618)
qiarie pushed a commit that referenced this pull request Jan 15, 2025
* Add progress indicator for report generation

* Add MeasureReportListScreen tests

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress dialog not displayed when in app reports are being generated
2 participants