Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated release notes #2611

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Add automated release notes #2611

merged 3 commits into from
Jul 27, 2023

Conversation

hilpitome
Copy link
Contributor

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@hilpitome hilpitome added DNM DO NOT MERGE Draft labels Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #2611 (eaf67f1) into main (d84c2c8) will decrease coverage by 0.1%.
Report is 30 commits behind head on main.
The diff coverage is 66.4%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2611     +/-   ##
=========================================
- Coverage     65.4%   65.3%   -0.1%     
- Complexity    1101    1148     +47     
=========================================
  Files          213     216      +3     
  Lines         9385    9744    +359     
  Branches      1866    1932     +66     
=========================================
+ Hits          6140    6372    +232     
- Misses        2047    2155    +108     
- Partials      1198    1217     +19     
Flag Coverage Δ
engine 73.1% <70.4%> (+<0.1%) ⬆️
geowidget 64.3% <37.5%> (+1.0%) ⬆️
quest 60.3% <63.8%> (-0.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ter/fhircore/engine/configuration/Configuration.kt 25.0% <ø> (ø)
...ngine/configuration/event/EventTriggerCondition.kt 50.0% <0.0%> (ø)
...ircore/engine/configuration/event/EventWorkflow.kt 33.3% <0.0%> (ø)
...ngine/configuration/view/PersonalDataProperties.kt 0.0% <0.0%> (ø)
...hircore/engine/configuration/view/RowProperties.kt 0.0% <ø> (ø)
...ine/configuration/view/ViewPropertiesSerializer.kt 23.8% <0.0%> (ø)
...data/remote/fhir/resource/FhirResourceConverter.kt 100.0% <ø> (ø)
...e/data/remote/fhir/resource/FhirResourceService.kt 0.0% <0.0%> (ø)
...hircore/engine/domain/model/FhirResourceConfigs.kt 44.4% <0.0%> (ø)
...rtregister/fhircore/engine/sync/SyncBroadcaster.kt 33.3% <0.0%> (ø)
... and 147 more

... and 20 files with indirect coverage changes

@pld
Copy link
Member

pld commented Jul 21, 2023

@hilpitome to have an example of what the output of this is? where it goes, stuff like that, thanks!

@hilpitome
Copy link
Contributor Author

The output from this will go to the release notes when making releases .
It should look like what we have in CHANGELOG.md. We can have the same categories of Added, Fixed and Changed or more depending on what we configure. The labels assigned for the PRs will then be used to set the PR titles as bullet points under the categories.

Currently, the release notes autogenerated by github just list the PR titles. With this configuration the labels will be used to group them appropriately.

An example output should be like below.

Added
- Insights feature to show stats on any Unsynced Resources on the device
- Generic date service function to add or subtract days, weeks, months or years from/to current date
Fixed
- Incorrect error shown for failed authentication when the credentials are invalid.
- [P2P] Possible p2p sync slow regression #2536
Changed
- Refactor register search to use SDK Search API to perform database query

cc @pld

@pld pld merged commit 4c18204 into main Jul 27, 2023
@pld pld deleted the automated-release-notes branch July 27, 2023 11:24
AbdulWahabMemon added a commit that referenced this pull request Aug 7, 2023
* main:
  Make SideMenu items scrollable (#2645)
  Add progress indicator for report generation (#2635)
  CHT measure report result screen (#2624)
  Provide missing QuestionnaireResponse in bundle param for FhirCarePlanGenerator#conditionallyUpdateResourceStatus (#2643)
  Fix resource closure failure after server sync (#2639)
  Fix build
  add more further reading (#2637)
  Refactor questionnaire implementation (#2622)
  Fix Unit Tests + Build 💚
  Fix Unit Tests ✅
  Clean up
  Fix Unit tests ✅
  Updating the login flow to save multiple practitioner details (#2623)
  Disable Dialog Dismiss Incase of Initial Sync Errors (#2608)
  Add the new ecbis production flavor
  Performance tests for loading register data (#2592)
  Fix back navigation for date selection page (#2628)
  Create github release file (#2611)
  Add form authoring consideration documentation (#2618)
qiarie pushed a commit that referenced this pull request Jan 15, 2025
Co-authored-by: Sharon Akinyi <79141719+sharon2719@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DNM DO NOT MERGE Draft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants