-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor questionnaire implementation #2622
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Display alert dialog when launching/performing extraction Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
To be fixed before removing the draft:
|
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
10 tasks
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2622 +/- ##
=========================================
- Coverage 65.4% 64.6% -0.8%
+ Complexity 1101 1075 -26
=========================================
Files 213 217 +4
Lines 9385 9555 +170
Branches 1866 1885 +19
=========================================
+ Hits 6140 6176 +36
- Misses 2047 2206 +159
+ Partials 1198 1173 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
pld
approved these changes
Aug 2, 2023
AbdulWahabMemon
added a commit
that referenced
this pull request
Aug 7, 2023
* main: Make SideMenu items scrollable (#2645) Add progress indicator for report generation (#2635) CHT measure report result screen (#2624) Provide missing QuestionnaireResponse in bundle param for FhirCarePlanGenerator#conditionallyUpdateResourceStatus (#2643) Fix resource closure failure after server sync (#2639) Fix build add more further reading (#2637) Refactor questionnaire implementation (#2622) Fix Unit Tests + Build 💚 Fix Unit Tests ✅ Clean up Fix Unit tests ✅ Updating the login flow to save multiple practitioner details (#2623) Disable Dialog Dismiss Incase of Initial Sync Errors (#2608) Add the new ecbis production flavor Performance tests for loading register data (#2592) Fix back navigation for date selection page (#2628) Create github release file (#2611) Add form authoring consideration documentation (#2618)
qiarie
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Implement QuestionnaireFragment and ViewModel Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Implement logic for perfroming extraction Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Fix extraction Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Clean up code Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Fix retrieval of subjectType Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Register questionnaire fragment listner after rendering Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Use SupervisorJob on coroutine Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Register group member Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Fix NoSuchElementException Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Configure deletion of resources via Questionnaire submission Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Launch refactored questionnaire activity Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Disable dark mode on all activities Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Implement functionality to populate resources Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Populate Questionnaire with previous responses Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Retrieve existing subject Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Show progress indicators Display alert dialog when launching/performing extraction Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Refactor QuestionnaireActivity and QuestionnaireViewModel classes Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Configure setting Barcode on Questionnaire Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Reinstate code for setting inital expression Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Delete unused xml layout Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Fix setting subject Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Fix updating resources Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Refactor engine module failing tests Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Refactor QuestionnaireViewModelTest Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Write test for QuestionnaireViewModel#handleQuestionnaireSubmission Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Write test for QuestionnaireActivity Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> * Test QuestionnaireActivity#onBackPress Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com> --------- Signed-off-by: Elly Kitoto <junkmailstoelly@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Work In Progress
Describes an items that is not complete. Mostly used for scoping issues of discussions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #2543
Fixes #2470
Fixes #2282
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file