Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve related resources without necessarily having to pass a reference to it #2595

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

Lentumunai-Mark
Copy link
Contributor

@Lentumunai-Mark Lentumunai-Mark commented Jul 17, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #2596

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

…ence.

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #2595 (fdae8b7) into main (d84c2c8) will increase coverage by 0.2%.
The diff coverage is 66.7%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #2595     +/-   ##
=========================================
+ Coverage     65.4%   65.6%   +0.2%     
- Complexity    1101    1135     +34     
=========================================
  Files          213     216      +3     
  Lines         9385    9658    +273     
  Branches      1866    1922     +56     
=========================================
+ Hits          6140    6343    +203     
- Misses        2047    2098     +51     
- Partials      1198    1217     +19     
Flag Coverage Δ
engine 73.0% <69.9%> (-0.1%) ⬇️
geowidget 62.9% <37.5%> (-0.3%) ⬇️
quest 60.8% <64.8%> (+0.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ter/fhircore/engine/configuration/Configuration.kt 25.0% <ø> (ø)
...ngine/configuration/event/EventTriggerCondition.kt 50.0% <0.0%> (ø)
...ircore/engine/configuration/event/EventWorkflow.kt 33.3% <0.0%> (ø)
...ore/engine/configuration/view/DividerProperties.kt 0.0% <0.0%> (ø)
...ngine/configuration/view/PersonalDataProperties.kt 0.0% <0.0%> (ø)
...hircore/engine/configuration/view/RowProperties.kt 0.0% <ø> (ø)
...ine/configuration/view/ViewPropertiesSerializer.kt 23.8% <0.0%> (ø)
...data/remote/fhir/resource/FhirResourceConverter.kt 100.0% <ø> (ø)
...e/data/remote/fhir/resource/FhirResourceService.kt 0.0% <0.0%> (ø)
...hircore/engine/domain/model/FhirResourceConfigs.kt 44.4% <0.0%> (ø)
... and 151 more

... and 13 files with indirect coverage changes

@pld pld merged commit ffaa1a2 into main Jul 17, 2023
@pld pld deleted the retrieve-related-resources-without-reference branch July 17, 2023 16:25
AbdulWahabMemon added a commit that referenced this pull request Jul 25, 2023
* main:
  Add View and Row widget documentation (#2614)
  Document spacer and divider widgets. (#2612)
  Add the Practitioner selection screen on the In-app reporting workflow (#2605)
  Add enableFamilyRegistration test for GeoWidgetfragment (#2607)
  Improved UX for non proxy mode development 🔨
  Update docs - added sync insights (#2600)
  Fixes the app showing a "Sync Complete" message even on sync failure (#2599)
  Retrieve related resources without necessarily having to pass a reference. (#2595)
  Add tests to verify LoginScreen error states (#2589)
  Rw docs update (#2588)
  Manifest Binaries request batching (#2583)
  remove about section (#2587)
  Pld doc updates (#2584)
  fix cname (#2586)
  Add Encounter_Location type (#2585)
  passing empty bundle instead of null to trigger the careplan when we don't have any bundle resource (#2432)
  Configure resource id for profile launch (#2581)
qiarie pushed a commit that referenced this pull request Jan 15, 2025
…ence. (#2595)

Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieve related resources without necessarily having to pass a reference.
2 participants