Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Encounter_Location Type #2585

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Add Encounter_Location Type #2585

merged 1 commit into from
Jul 13, 2023

Conversation

qiarie
Copy link
Contributor

@qiarie qiarie commented Jul 13, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number] or Closes #[issue number]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

Copy link
Contributor

@f-odhiambo f-odhiambo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR allows us to extract Ecounter.Location. In future will need to add to this file any Resource that needs to use the Backbone element

  1. https://build.fhir.org/encounter-definitions.html#Encounter.location
  2. https://build.fhir.org/types.html#BackBoneElement

CC @qiarie @dubdabasoduba @pld @ellykits @ndegwamartin

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #2585 (996a144) into main (d84c2c8) will increase coverage by 0.0%.
The diff coverage is 64.1%.

Impacted file tree graph

@@           Coverage Diff            @@
##              main   #2585    +/-   ##
========================================
  Coverage     65.4%   65.4%            
- Complexity    1101    1136    +35     
========================================
  Files          213     216     +3     
  Lines         9385    9652   +267     
  Branches      1866    1922    +56     
========================================
+ Hits          6140    6321   +181     
- Misses        2047    2113    +66     
- Partials      1198    1218    +20     
Flag Coverage Δ
engine 73.0% <69.6%> (-0.2%) ⬇️
geowidget 62.9% <37.5%> (-0.3%) ⬇️
quest 60.5% <60.5%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ter/fhircore/engine/configuration/Configuration.kt 25.0% <ø> (ø)
...ngine/configuration/event/EventTriggerCondition.kt 50.0% <0.0%> (ø)
...ircore/engine/configuration/event/EventWorkflow.kt 33.3% <0.0%> (ø)
...ore/engine/configuration/view/DividerProperties.kt 0.0% <0.0%> (ø)
...ngine/configuration/view/PersonalDataProperties.kt 0.0% <0.0%> (ø)
...hircore/engine/configuration/view/RowProperties.kt 0.0% <ø> (ø)
...ine/configuration/view/ViewPropertiesSerializer.kt 23.8% <0.0%> (ø)
...data/remote/fhir/resource/FhirResourceConverter.kt 100.0% <ø> (ø)
...e/data/remote/fhir/resource/FhirResourceService.kt 0.0% <0.0%> (ø)
...hircore/engine/domain/model/FhirResourceConfigs.kt 44.4% <0.0%> (ø)
... and 154 more

... and 12 files with indirect coverage changes

@pld
Copy link
Member

pld commented Jul 13, 2023

ok cool it feels pretty reasonable that we'll have to keep adding to that list of things we extract

@pld pld merged commit f1d3c13 into main Jul 13, 2023
@pld pld deleted the add-encounter-location-type branch July 13, 2023 20:48
AbdulWahabMemon added a commit that referenced this pull request Jul 25, 2023
* main:
  Add View and Row widget documentation (#2614)
  Document spacer and divider widgets. (#2612)
  Add the Practitioner selection screen on the In-app reporting workflow (#2605)
  Add enableFamilyRegistration test for GeoWidgetfragment (#2607)
  Improved UX for non proxy mode development 🔨
  Update docs - added sync insights (#2600)
  Fixes the app showing a "Sync Complete" message even on sync failure (#2599)
  Retrieve related resources without necessarily having to pass a reference. (#2595)
  Add tests to verify LoginScreen error states (#2589)
  Rw docs update (#2588)
  Manifest Binaries request batching (#2583)
  remove about section (#2587)
  Pld doc updates (#2584)
  fix cname (#2586)
  Add Encounter_Location type (#2585)
  passing empty bundle instead of null to trigger the careplan when we don't have any bundle resource (#2432)
  Configure resource id for profile launch (#2581)
qiarie added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants