-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests to verify LoginScreen error states #2589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2589 +/- ##
=========================================
+ Coverage 65.4% 65.6% +0.2%
- Complexity 1101 1135 +34
=========================================
Files 213 216 +3
Lines 9385 9654 +269
Branches 1866 1922 +56
=========================================
+ Hits 6140 6339 +199
- Misses 2047 2098 +51
- Partials 1198 1217 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pld
previously approved these changes
Jul 14, 2023
pld
previously approved these changes
Jul 14, 2023
pld
approved these changes
Jul 14, 2023
AbdulWahabMemon
added a commit
that referenced
this pull request
Jul 25, 2023
* main: Add View and Row widget documentation (#2614) Document spacer and divider widgets. (#2612) Add the Practitioner selection screen on the In-app reporting workflow (#2605) Add enableFamilyRegistration test for GeoWidgetfragment (#2607) Improved UX for non proxy mode development 🔨 Update docs - added sync insights (#2600) Fixes the app showing a "Sync Complete" message even on sync failure (#2599) Retrieve related resources without necessarily having to pass a reference. (#2595) Add tests to verify LoginScreen error states (#2589) Rw docs update (#2588) Manifest Binaries request batching (#2583) remove about section (#2587) Pld doc updates (#2584) fix cname (#2586) Add Encounter_Location type (#2585) passing empty bundle instead of null to trigger the careplan when we don't have any bundle resource (#2432) Configure resource id for profile launch (#2581)
qiarie
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Add LoginScreen tests to verify different error states * spotless * spotless --------- Co-authored-by: pld <peter@ona.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist
strings.xml
file./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the project's style guideCode Reviewer Checklist
strings.xml
file