Introduce protocol version 3 #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2025
lzpap
reviewed
Jan 13, 2025
* fix(iota-framework): fixed `CoinManager` metadata immutability validation * feat: create the protocol version `3` * fix(iota-framework): `CoinManager` maximum supply check is fixed * fix(iota-framework-snapshot): the snapshot is updated * fix: update test snapshots * fix(iota-framework): removed extra assert from the `CoinManager::add_additional_metadata` function * fix(iota-framework-snapshot): the snapshot is updated * fix: update test snapshots * fix(iota-json-rpc-tests): changed the coin package serialization in `create_and_mint_coins` * fix(iota-graphql-e2e-tests): the snapshots update
#4759) * feat(iota-framework): added clock-based methods to the timelock module * fix(iota-framework-snapshot): update the snapshot * fix: update test snapshots * fix(iota-graphql-e2e-tests): the snapshots update
… relocation (#19672)` (#4712) * Merge from sui@59f115b * Update snapshots and the generated files * Set relocate_event_module config in version 3 * Remove the new config from old snapshots * Update the openrpc.json * Add regression test * Convert the modification for version_2.snap * Add protocol config change record * Fix typo * Fmt
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Skipped Deployments
|
alexsporn
commented
Jan 14, 2025
…st fix (#4769) * fix(iota-framework): the `test_expiration_time_is_passed` timelock test fix * fix(iota-framework): added a `test_unlock_with_clock_expiration_time_is_passed` test
…why there are 2 events from the nft module
lzpap
reviewed
Jan 15, 2025
lzpap
approved these changes
Jan 15, 2025
thibault-martinez
approved these changes
Jan 15, 2025
DaughterOfMars
changed the title
Co-authored-by: Levente Pap <levente.pap@iota.org>
alexsporn
force-pushed
the
core-protocol/procotol-version-3
branch
from
604ab48 to
6135a14
Compare
miker83z
approved these changes
Jan 15, 2025
cyberphysic4l
approved these changes
Jan 15, 2025
| /// The error returned if you try to edit immutable metadata | ||
| const ENoMutableMetadata: u64 = 5; | ||
| /// The maximum supply supported by `CoinManager` | ||
| const MAX_SUPPLY: u64 = 18_446_744_073_709_551_614u64; |
There was a problem hiding this comment.
Is there a reason this decreased by 1 from the number used below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Feature branch to introduce protocol version 3