fix(iota-framework): the test_expiration_time_is_passed timelock test fix
#4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriyr
added
sc-platform
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Deployment failed with the following error: |
|
This pull request has been deployed to Vercel. Latest commit: c855f00 |
lzpap
approved these changes
Jan 14, 2025
Thoralf-M
approved these changes
Jan 14, 2025
|
This pull request has been deployed to Vercel. Latest commit: c855f00 ✅ Preview: https://rebased-explorer-aczl7ux5x-iota1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: c855f00 ✅ Preview: https://wallet-dashboard-f8n6apeqg-iota1.vercel.app |
alexsporn
merged commit f950ba9
into
core-protocol/procotol-version-3
40 of 46 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The test should be fixed to check if the locked value can be unlocked.
This change doesn't affect the framework version or snapshots because tests are not included in the framework bytecode.
Also added the same test to check an object unlocking using the
Clock.