Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): Merge bug fix from upstream changes: event sending module relocation (#19672) #4712

Merged
merged 11 commits into from
Jan 14, 2025
Merged

fix(node): Merge bug fix from upstream changes: event sending module relocation (#19672) #4712

merged 11 commits into from
Jan 14, 2025

Conversation

bingyanglin
Copy link
Contributor

@bingyanglin bingyanglin commented Jan 8, 2025 •
edited
Loading

Description of change

Merge the bug fixing PR from upstream: core: event sending module relocation (#19672) · MystenLabs/sui@59f115b

  • Update the protocol and associated logic
  • Port/check the associated regression testing

Links to any relevant issues

Fixes #4668

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

Build and run the node from source, and sync with other nodes by following the guide and execute

cargo run --release --bin iota-node -- --config-path fullnode.yaml

Also ran scripts/generate_files/update_generated_files.sh.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@bingyanglin bingyanglin added the node Issues related to the Core Node team label Jan 8, 2025
@bingyanglin bingyanglin self-assigned this Jan 8, 2025
@bingyanglin bingyanglin requested review from a team as code owners January 8, 2025 08:07
@alexsporn
Copy link
Member

Warning! this is a procotol-changing commit, do NOT merge yet. This needs to be planned into a protocol upgrade.

@alexsporn
Copy link
Member

@bingyanglin please also port the referenced regression tests from upstream

@bingyanglin
Copy link
Contributor Author

Warning! this is a procotol-changing commit, do NOT merge yet. This needs to be planned into a protocol upgrade.

Thanks for the warning. I put it in the description.

@bingyanglin bingyanglin marked this pull request as draft January 8, 2025 09:02
@bingyanglin bingyanglin marked this pull request as ready for review January 10, 2025 08:11
@bingyanglin bingyanglin requested a review from a team as a code owner January 10, 2025 08:11
@bingyanglin bingyanglin changed the base branch from develop to core-protocol/procotol-version-3 January 10, 2025 08:12
@alexsporn
Copy link
Member

You can target the #4741 feature branch

@bingyanglin bingyanglin force-pushed the core-node/bug-fix/sui@59f115b branch from 7bb749b to 5204617 Compare January 10, 2025 08:19
miker83z
miker83z approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@miker83z miker83z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug fix pull looks good! The tests errors are related to the new protocol upgrade, idk if it is worth to solve those in this branch or in the core-protocol/procotol-version-3 one when all the other related PRs are merged.

@bingyanglin
Copy link
Contributor Author

The bug fix pull looks good! The tests errors are related to the new protocol upgrade, idk if it is worth to solve those in this branch or in the core-protocol/procotol-version-3 one when all the other related PRs are merged.

Thanks. Yeah I guess it would be easier to generate the new .snap files in the core-protocol/procotol-version-3 branch directly after merging other PRs.

@vercel Vercel
Copy link

vercel bot commented Jan 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apps-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 9:57am
apps-ui-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 9:57am
wallet-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 9:57am

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 39c1b71

✅ Preview: https://apps-backend-1jb1x7r09-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 39c1b71

✅ Preview: https://rebased-explorer-jayhim66h-iota1.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 39c1b71

✅ Preview: https://wallet-dashboard-1rwa8zvt1-iota1.vercel.app

@alexsporn alexsporn merged commit 71d8593 into core-protocol/procotol-version-3 Jan 14, 2025
43 of 46 checks passed
@alexsporn alexsporn deleted the core-node/bug-fix/sui@59f115b branch January 14, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsporn alexsporn alexsporn left review comments

@miker83z miker83z miker83z approved these changes

Assignees

@bingyanglin bingyanglin

Labels
core-protocol node Issues related to the Core Node team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

core: event sending module relocation (#19672) · MystenLabs/sui@59f115b
4 participants
@bingyanglin @alexsporn @miker83z @iota-ci