fix(iota-framework): audit issues fix #4743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…additional_metadata` function
…create_and_mint_coins`
…e-additional-metadata-check fix(iota-framework): removed extra assert from the `CoinManager::add_additional_metadata` function
…manager-max-supply fix(iota-framework): `CoinManager` maximum supply check is fixed
…manager-metadata-update fix(iota-framework): fixed `CoinManager` metadata immutability validation
iota-ci
added
sc-platform
valeriyr
added
vm-language
…e-4592-audit-fixes
valeriyr
force-pushed
the
sc-platform/issue-4592-audit-fixes
branch
from
e097872 to
a1a2cd7
Compare
muXxer
reviewed
Jan 10, 2025
crates/iota-graphql-e2e-tests/tests/transaction_block_effects/balance_changes.exp
Show resolved
Hide resolved
| @@ -166,7 +166,7 @@ Response: { | |||
| "effects", | |||
| "objectChanges", | |||
| "nodes", | |||
| 0, | |||
| 2, | |||
There was a problem hiding this comment.
Is that because of the bugfix?
crates/iota-graphql-e2e-tests/tests/consistency/dynamic_fields/deleted_df.exp
Show resolved
Hide resolved
| "edges": [] | ||
| } | ||
| }, | ||
| "coins_before_obj_3_0_chkpt_3": { |
There was a problem hiding this comment.
is it ok that the coins are now in "after checkpoint" and before they where in "before"?
There was a problem hiding this comment.
yes, they changed the order.
|
@kodemartin Can you, please, approve the graphql tests change. The protocol version used in the tests was changed in the base branch to |
muXxer
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR contains all the audit fixes related to the following issues.
Links to any relevant issues
fixes #4592
fixes #4593
fixes #4595
fixes #4596