Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove private repository ssh workarounds #4108

Merged
merged 8 commits into from
Nov 19, 2024
Merged

feat: remove private repository ssh workarounds #4108

merged 8 commits into from
Nov 19, 2024

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Nov 18, 2024 •
edited
Loading

Description of change

This PR reverts all the changes made for making the repository work with the following private repositories:

https://github.com/iotaledger/iota-rust-sdk
https://github.com/iotaledger/tokio-madsim-fork
https://github.com/iotaledger/iota-sim

Links to any relevant issues

Fixes #2149

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

I couldn't test it yet, because the repos are still private.

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer added the node Issues related to the Core Node team label Nov 18, 2024
@thibault-martinez thibault-martinez requested a review from a team as a code owner November 19, 2024 10:41
@muXxer muXxer force-pushed the core-node/feat/remove-private-repo-ssh-hack branch 2 times, most recently from ec67931 to 11d32ba Compare November 19, 2024 14:47
@muXxer muXxer force-pushed the core-node/feat/remove-private-repo-ssh-hack branch from 11d32ba to c85437d Compare November 19, 2024 14:59
@muXxer muXxer merged commit 44c7f37 into develop Nov 19, 2024
38 of 40 checks passed
@muXxer muXxer deleted the core-node/feat/remove-private-repo-ssh-hack branch November 19, 2024 15:49
muXxer added a commit that referenced this pull request Nov 19, 2024
@muXxer @Thoralf-M
feat: remove private repository ssh workarounds (#4108)
e337211 
* Revert "Fix: Docker builds (#2289)"

This reverts commit b9e01fe.

* Revert "chore(CI): Use SSH for docker builds (#2246)"

This reverts commit bb019d4.

* feat(docker): remove private repository ssh workaround

* feat(git): change git references of private repos to https

* feat(move-tests): reenable nested deps git local test

* feat(docker): replace private docker registry

* feat(iota): reenable test_move_new (#4122)

* chore: update iota-sim commit hash

---------

Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
@muXxer muXxer mentioned this pull request Nov 19, 2024
Merged
6 tasks
@thibault-martinez thibault-martinez mentioned this pull request Nov 19, 2024
Closed
Thoralf-M added a commit that referenced this pull request Nov 20, 2024
@muXxer @Thoralf-M
feat: remove private repository ssh workarounds (#4108)
64f88dc 
* Revert "Fix: Docker builds (#2289)"

This reverts commit b9e01fe.

* Revert "chore(CI): Use SSH for docker builds (#2246)"

This reverts commit bb019d4.

* feat(docker): remove private repository ssh workaround

* feat(git): change git references of private repos to https

* feat(move-tests): reenable nested deps git local test

* feat(docker): replace private docker registry

* feat(iota): reenable test_move_new (#4122)

* chore: update iota-sim commit hash

---------

Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
@Thoralf-M Thoralf-M mentioned this pull request Nov 20, 2024
Closed
alexsporn pushed a commit that referenced this pull request Nov 20, 2024
@muXxer @Thoralf-M
feat: remove private repository ssh workarounds (#4108) (#4139)
39c83dd 
* Revert "Fix: Docker builds (#2289)"

This reverts commit b9e01fe.

* Revert "chore(CI): Use SSH for docker builds (#2246)"

This reverts commit bb019d4.

* feat(docker): remove private repository ssh workaround

* feat(git): change git references of private repos to https

* feat(move-tests): reenable nested deps git local test

* feat(docker): replace private docker registry

* feat(iota): reenable test_move_new (#4122)

* chore: update iota-sim commit hash

---------

Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
@thibault-martinez thibault-martinez mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@alexsporn alexsporn alexsporn approved these changes

@DaughterOfMars DaughterOfMars DaughterOfMars approved these changes

@miker83z miker83z miker83z approved these changes

@sergiupopescu199 sergiupopescu199 sergiupopescu199 approved these changes

@msarcev msarcev Awaiting requested review from msarcev msarcev is a code owner

@Dr-Electron Dr-Electron Awaiting requested review from Dr-Electron Dr-Electron is a code owner

@valeriyr valeriyr Awaiting requested review from valeriyr

Assignees
No one assigned
Labels
node Issues related to the Core Node team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task (*)]: Chores when repository becomes public
7 participants
@muXxer @thibault-martinez @alexsporn @DaughterOfMars @miker83z @sergiupopescu199 @Thoralf-M