-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): Use SSH for docker builds #2246
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c22454d.
This reverts commit 834669a.
lzpap
approved these changes
Sep 4, 2024
…iota into dev-tools/ssh-docker
sergiupopescu199
approved these changes
Sep 4, 2024
thibault-martinez
approved these changes
Sep 4, 2024
4 tasks
Thoralf-M
pushed a commit
that referenced
this pull request
Nov 19, 2024
This reverts commit bb019d4.
muXxer
added a commit
that referenced
this pull request
Nov 19, 2024
* Revert "Fix: Docker builds (#2289)" This reverts commit b9e01fe. * Revert "chore(CI): Use SSH for docker builds (#2246)" This reverts commit bb019d4. * feat(docker): remove private repository ssh workaround * feat(git): change git references of private repos to https * feat(move-tests): reenable nested deps git local test * feat(docker): replace private docker registry * feat(iota): reenable test_move_new (#4122) * chore: update iota-sim commit hash --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
muXxer
added a commit
that referenced
this pull request
Nov 19, 2024
* Revert "Fix: Docker builds (#2289)" This reverts commit b9e01fe. * Revert "chore(CI): Use SSH for docker builds (#2246)" This reverts commit bb019d4. * feat(docker): remove private repository ssh workaround * feat(git): change git references of private repos to https * feat(move-tests): reenable nested deps git local test * feat(docker): replace private docker registry * feat(iota): reenable test_move_new (#4122) * chore: update iota-sim commit hash --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Thoralf-M
added a commit
that referenced
this pull request
Nov 20, 2024
* Revert "Fix: Docker builds (#2289)" This reverts commit b9e01fe. * Revert "chore(CI): Use SSH for docker builds (#2246)" This reverts commit bb019d4. * feat(docker): remove private repository ssh workaround * feat(git): change git references of private repos to https * feat(move-tests): reenable nested deps git local test * feat(docker): replace private docker registry * feat(iota): reenable test_move_new (#4122) * chore: update iota-sim commit hash --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
alexsporn
pushed a commit
that referenced
this pull request
Nov 20, 2024
* Revert "Fix: Docker builds (#2289)" This reverts commit b9e01fe. * Revert "chore(CI): Use SSH for docker builds (#2246)" This reverts commit bb019d4. * feat(docker): remove private repository ssh workaround * feat(git): change git references of private repos to https * feat(move-tests): reenable nested deps git local test * feat(docker): replace private docker registry * feat(iota): reenable test_move_new (#4122) * chore: update iota-sim commit hash --------- Co-authored-by: Thoralf-M <46689931+Thoralf-M@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Docker builds in the CI cannot run without SSH due to the private repository
iota-sim
. This PR adds some setup to allow this.