Fix length check on dns_rfc1035_label tag #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zemzale this needs another approval - can you poke someone? :) |
|
@KimNorgaard Could you resolve the conflicts so we can proceed with the merge? |
**fix for aliases** translate work incorrect for registered aliases ## Fixes Or Enhances **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
…nese Taiwan (go-playground#1170) ## Fixes Or Enhances Add translation of below in English/Chinese/Chinese Taiwan : required_unless required_with required_with_all required_without required_without_all excluded_if excluded_unless excluded_with excluded_with_all excluded_without excluded_without_all **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
Updated all library dependencies. - Addresses dependabot alerts. - closes go-playground#1205 go-playground#1220 ## Fixes Or Enhances **Make sure that you've checked the boxes below before you submit PR:** - [ ] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers Co-authored-by: Dean Karn <deankarn@reaver1.local>
…ound#1234) ## Add supporting for validation private fields go-playground#417 @go-playground/validator-maintainers --------- Co-authored-by: nikolay <n.anohin@lucky.online>
## Fixes ULID should case-insensitive @go-playground/validator-maintainers
## Enhances **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Enhances Added MongoDB connection string validation **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
Closes go-playground#1269 ## Fixes Or Enhances **Make sure that you've checked the boxes below before you submit PR:** - [ ] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances Typos and other grammar issues in comments, tests, and field names. @go-playground/validator-maintainers
…yground#1261) `required` validates that the value is not the data types default zero value. For `boolean` the default zero value is `false`. Therefore, a `false` boolean value would be interpreted as not matching the `required` validation and fail. This, in my opinion, is a little unexpected. Judging from the name `required` only, I expected that a `false` boolean value would be ok, since a value was provided. Nevertheless, in my opinion, this behavior should be documented a little more explicitly. Which is why I propose this change to the docs. - [x] Tests exist or have been written that cover this particular change. (this is only a docs change) @go-playground/validator-maintainers
…o-playground#1250) ## Fixes In English version, max-items error message is `"{0} must contain at maximum {1}"`. ([ref](https://github.com/go-playground/validator/blob/master/translations/en/en.go#L292)) And current Japanese translation `"{0}は最大でも{1}を含まなければなりません"` is strait translation of English version but quite unnatural for Japanese. We don’t usually use a sentence like `"含まなければなりません"` ("must contain") in this context. Because it can not **"contain"** any items further. So, we simply say `"{0}は最大でも{1}でなければなりません"` ("{0} must be at maximum {1}") instead. `"lt-items"` and `"lte-items"` messages have same issue as above. (if those errors occur, it can not contain any items further as well.) --- **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers Signed-off-by: pavedroad <qcqs@outlook.com>
Hey. Here's my implementation of polish language translations that I created for my application and other devs may find attractive. ## Fixes Or Enhances `validator` package supports polish language after this MR is accepted. **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
Using `GODEBUG=inittrace=1` I found a relatively constant 10ms init caused by this function. Replaces go-playground#1246. @go-playground/validator-maintainers
## Enhances **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances Resolves go-playground#1259 **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances Mention 'enum' in the documentation for `oneof`. One of our team member spent too much time looking for an 'enum-like' validation tag, only to find out later that `oneof` exists. This PR intends on making the discovery of this validation tag easier. **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances - Adds oneofci, a case insensitive version of oneof - resolves go-playground#840 **Make sure that you've checked the boxes below before you submit PR:** - [ X] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances This PR adds a new validation for numeric ports. Connected to: go-playground#1216 ``` type Host struct { Port uint32 `validate:"port"` } ``` **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances This adds and documents the MSGV(Minimum Supported Go Version) package details originally being discussed [here](go-playground#1342). Along with the documentation changes the MSGV was bumped to Go 1.20 to address a security issue and updating to the latest version of `github.com/gabriel-vasile/mimetype` which increased their MSGV to v1.20 while addressing the same fix. While here re-ran and updated the benchmarks section for never version of Go.
Fixed an issue where the post codes regexes would not get initialised for postcode_iso3166_alpha2_field validation. ## Fixes Or Enhances **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
…dge (go-playground#1362) ## Fixes Or Enhances `go-playground/validator` doesn't use TravisCI. **Make sure that you've checked the boxes below before you submit PR:** - [ ] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances fix issue go-playground#763 **Make sure that you've checked the boxes below before you submit PR:** - [ ] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances **Make sure that you've checked the boxes below before you submit PR:** - [ ] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers --------- Co-authored-by: Ganeshdip Dumbare <ganeshdip.dumbare@qonto.com>
…ncluding nil pointer and empty content of pointer) (go-playground#1289) ## Fixes Or Enhances **Add the `omitzero` Tag:** - It allows you to ignore the subsequent validations if the value of a field is empty - If the field is a pointer and the pointer is nil, ignore the subsequent validations - If the field is a pointer and the pointer is not nil, but the content value of the pointer is zero, the subsequent validations will be ignored **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
…be interface or implement error" in examples. (go-playground#1378) Only *InvalidValidationError implements error, so we must use double pointer. good explanation: https://www.reddit.com/r/golang/comments/txi397/comment/i3lybab/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button and https://stackoverflow.com/a/69448087/9066110 ## Fixes Or Enhances Fixes `panic: errors: *target must be interface or implement error` for `_examples/simple/` and `_examples/struct-level/` that was introduced in go-playground#1346 **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances This PR adds a `dependabot.yml` configuration file to enable automated dependency updates for: - Golang - GitHub Actions **Make sure that you've checked the boxes below before you submit PR:** - [ ] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4 to 6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint-action/releases">golangci/golangci-lint-action's releases</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <p>This version removes <code>annotations</code> option (because it was useless), and removes the default output format (<code>github-actions</code>). The annotations are still produced but with another approach.</p> <h3>Changes</h3> <ul> <li>feat: rewrite format handling by <a href="https://github.com/ldez"><code>@ldez</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1038">golangci/golangci-lint-action#1038</a></li> </ul> <h3>Dependencies</h3> <ul> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 7.7.1 to 7.8.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1034">golangci/golangci-lint-action#1034</a></li> <li>build(deps): bump <code>@types/node</code> from 20.12.7 to 20.12.8 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1036">golangci/golangci-lint-action#1036</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 7.7.1 to 7.8.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1035">golangci/golangci-lint-action#1035</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v5.3.0...v6.0.0">https://github.com/golangci/golangci-lint-action/compare/v5.3.0...v6.0.0</a></p> <h2>v5.3.0</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>Changes</h3> <ul> <li>feat: uses 2 dots compare syntax for push diff by <a href="https://github.com/ldez"><code>@ldez</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1030">golangci/golangci-lint-action#1030</a></li> <li>feat: add option to control cache invalidation interval by <a href="https://github.com/ldez"><code>@ldez</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1031">golangci/golangci-lint-action#1031</a></li> <li>feat: use OS and working-directory as cache key by <a href="https://github.com/ldez"><code>@ldez</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1032">golangci/golangci-lint-action#1032</a></li> <li>feat: improve log about pwd/cwd by <a href="https://github.com/ldez"><code>@ldez</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1033">golangci/golangci-lint-action#1033</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v5.2.0...v5.3.0">https://github.com/golangci/golangci-lint-action/compare/v5.2.0...v5.3.0</a></p> <h2>v5.2.0</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>Changes</h3> <ul> <li><a href="https://github.com/golangci/golangci-lint-action/commit/aebff4bd9cd0198ff4f020915c27258a9edc4c01">feat: add an option to enable/disable annotations</a> by <a href="https://github.com/ldez"><code>@ldez</code></a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/golangci/golangci-lint-action/compare/v5.1.0...v5.2.0">https://github.com/golangci/golangci-lint-action/compare/v5.1.0...v5.2.0</a></p> <h2>v5.1.0</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>Changes</h3> <ul> <li>feat: support for <code>pull</code> and <code>merge_group</code> events with the option <code>only-new-issues</code> by <a href="https://github.com/ldez"><code>@ldez</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1029">golangci/golangci-lint-action#1029</a></li> </ul> <h3>Dependencies</h3> <ul> <li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from 7.7.0 to 7.7.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1027">golangci/golangci-lint-action#1027</a></li> <li>build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code> from 7.7.0 to 7.7.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/golangci/golangci-lint-action/pull/1028">golangci/golangci-lint-action#1028</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golangci/golangci-lint-action/commit/2226d7cb06a077cd73e56eedd38eecad18e5d837"><code>2226d7c</code></a> 6.5.0</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/8d744d5b7f56a6baec6cc8b5f32947e1f52d05fc"><code>8d744d5</code></a> feat: verify with the JSONSchema by default (<a href="https://redirect.github.com/golangci/golangci-lint-action/issues/1171">#1171</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/0e58f8e7ab750dc8bf4ac7eeb8a6993a2aaeef8c"><code>0e58f8e</code></a> build(deps): bump <code>@octokit/endpoint</code> from 9.0.5 to 9.0.6 (<a href="https://redirect.github.com/golangci/golangci-lint-action/issues/1170">#1170</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/6a3fb764d508e4ba6bec7000b7c7a827384ec250"><code>6a3fb76</code></a> build(deps): bump <code>@octokit/request-error</code> from 5.1.0 to 5.1.1 (<a href="https://redirect.github.com/golangci/golangci-lint-action/issues/1169">#1169</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/696fa5c0e74367806ce8ce43eb0f19a8a0d3e91a"><code>696fa5c</code></a> chore: clean workflows</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/80284ede25727d22b2f0d91af5f6fab0edb570bd"><code>80284ed</code></a> chore: use ubuntu-22.04-arm</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/818ec4d51a1feacefc42ff1b3ec25d4962690f39"><code>818ec4d</code></a> 6.4.1</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/1c50240be21009d0894c6d1a4daf27fc74c19fca"><code>1c50240</code></a> fix: use config arg for verify (<a href="https://redirect.github.com/golangci/golangci-lint-action/issues/1168">#1168</a>)</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/0adbc47a5910e47adb692df88187ec8c73c76778"><code>0adbc47</code></a> 6.4.0</li> <li><a href="https://github.com/golangci/golangci-lint-action/commit/f7463c56f6527097c8fff14480d3a4fa81ccdb81"><code>f7463c5</code></a> feat: add an option to verify with the JSONSchema (<a href="https://redirect.github.com/golangci/golangci-lint-action/issues/1167">#1167</a>)</li> <li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint-action/compare/v4...v6">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.21.0 to 0.22.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/text/commit/3b64043c9e8fa8cd61a019df17dc729630915fa9"><code>3b64043</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/text/commit/1e59086680cc4c90cd7e9a2f5fcf98043df4396c"><code>1e59086</code></a> message/pipeline: add two Unalias calls</li> <li>See full diff in <a href="https://github.com/golang/text/compare/v0.21.0...v0.22.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.32.0 to 0.33.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/crypto/commit/9290511cd23ab9813a307b7f2615325e3ca98902"><code>9290511</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/golang/crypto/commit/fa5273e461966728f91f33da62c0cf511a404c2a"><code>fa5273e</code></a> x509roots/fallback: update bundle</li> <li><a href="https://github.com/golang/crypto/commit/a8ea4be81f0769fd5857e087083cbb6d3cb9f196"><code>a8ea4be</code></a> ssh: add ServerConfig.PreAuthConnCallback, ServerPreAuthConn (banner) interface</li> <li><a href="https://github.com/golang/crypto/commit/71d3a4cfdb0360795ce5f2d7041e01823fd22eb6"><code>71d3a4c</code></a> acme: support challenges that require the ACME client to send a non-empty JSO...</li> <li>See full diff in <a href="https://github.com/golang/crypto/compare/v0.32.0...v0.33.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…-playground#1376) ## Enhances - Add comprehensive test coverage for all validation tags - Improve Indonesian translation messages for better clarity - Add tests for field, network, string, format, comparison, other, and alias tags - Ensure consistent translation style across all validation messages - Follow idiomatic Indonesian language patterns - Grouping each tags based on README.md (Field, Network, Strings, etc.) ### Tests cover: - Field validations (required, min, max, etc.) - Network validations (email, ip, url, etc.) - String validations (alpha, contains, etc.) - Format validations (datetime, uuid, etc.) - Comparison validations (eq, gt, lt, etc.) - Other validations (file, unique, etc.) - Alias validations (color, country code) **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances This PR adds `time.Duration` translation and unit test cases. Connected to: go-playground#1069 **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances This PR updates 'Project Status' button in README.md file to automatically display the latest release version. No manual editing of the release version in the README.md file is required. <img width="740" alt="image" src="https://github.com/user-attachments/assets/cf40b0c1-afa4-4499-b80b-a9aba118614b" /> **Make sure that you've checked the boxes below before you submit PR:** - [ ] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances go-playground#1365 <img width="656" alt="image" src="https://github.com/user-attachments/assets/f16ded3b-c918-42a9-8e13-02aa2474960b" /> **Make sure that you've checked the boxes below before you submit PR:** - [ ] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
## Fixes Or Enhances The usage of Base64RawURL was incorrect. **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
Yes, just resolved it and I apparently managed to fumble the rebase. Sorry about that. Will you be able to squash it? |
nodivbyzero
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Fix length check on dns_rfc1035_label tag.
Fixes #1213
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers