Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove gitter.im link from README.md #1366

Merged
merged 4 commits into from
Feb 25, 2025
Merged

Remove gitter.im link from README.md #1366

merged 4 commits into from
Feb 25, 2025
+1 −2

Conversation

nodivbyzero
Copy link
Contributor

@nodivbyzero nodivbyzero commented Jan 23, 2025 •
edited
Loading

Fixes Or Enhances

#1365

image

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@nodivbyzero nodivbyzero requested a review from a team as a code owner January 23, 2025 00:37
@coveralls
Copy link

coveralls commented Jan 23, 2025 •
edited
Loading

Coverage Status

coverage: 75.291%. remained the same
when pulling e805052 on nodivbyzero:rm-gitter-im-link
into 378f26e on go-playground:master.

alob-mtc
alob-mtc approved these changes Feb 2, 2025
View reviewed changes
Copy link

@alob-mtc alob-mtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodivbyzero
Copy link
Contributor Author

@deankarn @zemzale please review when you have time

@nodivbyzero nodivbyzero merged commit c9db2a0 into go-playground:master Feb 25, 2025
15 checks passed
KimNorgaard pushed a commit to KimNorgaard/validator that referenced this pull request Feb 25, 2025
@nodivbyzero @KimNorgaard
Remove gitter.im link from README.md (go-playground#1366)
b823ecf 
## Fixes Or Enhances

go-playground#1365

<img width="656" alt="image"
src="https://github.com/user-attachments/assets/f16ded3b-c918-42a9-8e13-02aa2474960b"
/>


**Make sure that you've checked the boxes below before you submit PR:**
- [ ] Tests exist or have been written that cover this particular
change.

@go-playground/validator-maintainers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

@alob-mtc alob-mtc alob-mtc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodivbyzero @coveralls @deankarn @alob-mtc