chore: using errors.As instead of type assertion #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this change fix the issue #763? |
ccoVeille
suggested changes
Dec 17, 2024
ccoVeille
approved these changes
Jan 8, 2025
deankarn
approved these changes
Jan 13, 2025
1 task
deankarn
pushed a commit
that referenced
this pull request
Feb 18, 2025
…be interface or implement error" in examples. (#1378) Only *InvalidValidationError implements error, so we must use double pointer. good explanation: https://www.reddit.com/r/golang/comments/txi397/comment/i3lybab/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button and https://stackoverflow.com/a/69448087/9066110 ## Fixes Or Enhances Fixes `panic: errors: *target must be interface or implement error` for `_examples/simple/` and `_examples/struct-level/` that was introduced in #1346 **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
KimNorgaard
pushed a commit
to KimNorgaard/validator
that referenced
this pull request
Feb 25, 2025
## Fixes Or Enhances fix issue go-playground#763 **Make sure that you've checked the boxes below before you submit PR:** - [ ] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
KimNorgaard
pushed a commit
to KimNorgaard/validator
that referenced
this pull request
Feb 25, 2025
…be interface or implement error" in examples. (go-playground#1378) Only *InvalidValidationError implements error, so we must use double pointer. good explanation: https://www.reddit.com/r/golang/comments/txi397/comment/i3lybab/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button and https://stackoverflow.com/a/69448087/9066110 ## Fixes Or Enhances Fixes `panic: errors: *target must be interface or implement error` for `_examples/simple/` and `_examples/struct-level/` that was introduced in go-playground#1346 **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. @go-playground/validator-maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
fix issue #763
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers