Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(translations): improve Indonesian translations and add tests #1376

Conversation

fathiraz
Copy link
Contributor

Enhances

  • Add comprehensive test coverage for all validation tags
  • Improve Indonesian translation messages for better clarity
  • Add tests for field, network, string, format, comparison, other, and alias tags
  • Ensure consistent translation style across all validation messages
  • Follow idiomatic Indonesian language patterns
  • Grouping each tags based on README.md (Field, Network, Strings, etc.)

Tests cover:

  • Field validations (required, min, max, etc.)
  • Network validations (email, ip, url, etc.)
  • String validations (alpha, contains, etc.)
  • Format validations (datetime, uuid, etc.)
  • Comparison validations (eq, gt, lt, etc.)
  • Other validations (file, unique, etc.)
  • Alias validations (color, country code)

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@fathiraz fathiraz requested a review from a team as a code owner February 14, 2025 11:23
@coveralls
Copy link

coveralls commented Feb 14, 2025

Coverage Status

coverage: 75.251% (+0.9%) from 74.319%
when pulling 94c81b5 on fathiraz:feat/improve-indonesian-translations-and-add-tests
into e564451 on go-playground:master.

@nodivbyzero nodivbyzero merged commit 002f6c6 into go-playground:master Feb 20, 2025
15 checks passed
KimNorgaard pushed a commit to KimNorgaard/validator that referenced this pull request Feb 25, 2025
…-playground#1376)

## Enhances
- Add comprehensive test coverage for all validation tags
- Improve Indonesian translation messages for better clarity
- Add tests for field, network, string, format, comparison, other, and
alias tags
- Ensure consistent translation style across all validation messages
- Follow idiomatic Indonesian language patterns
- Grouping each tags based on README.md (Field, Network, Strings, etc.)

### Tests cover:
- Field validations (required, min, max, etc.)
- Network validations (email, ip, url, etc.)
- String validations (alpha, contains, etc.)
- Format validations (datetime, uuid, etc.)
- Comparison validations (eq, gt, lt, etc.)
- Other validations (file, unique, etc.)
- Alias validations (color, country code)

**Make sure that you've checked the boxes below before you submit PR:**
- [x] Tests exist or have been written that cover this particular
change.

@go-playground/validator-maintainers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants