services/header: Refactor HeaderService to be responsible for broadcasting new ExtendedHeaders to the gossipsub network
#327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
changed the title
HeaderService to be responsible for broadcasting new ExtendedHeaders to the gossipsub network
Closed
2 tasks
Wondertan
reviewed
Jan 6, 2022
|
@renaynay, a tip: if you add changelogs to the top then there won't be any conflicts. Also, it makes the ordering nice where top changes are recent ones |
feat(service/header): make a helper to assemble ExtendedHeaders refactor(service/header): make core exchange to rely on new helpers refactor(service/header): make core listener to rely on new helpers refactor(node/core): rework construction of core exchange refactor(service): remove erasure as redudandant chore: lint
liamsi
previously approved these changes
Jan 7, 2022
* fix(core): wrap errors instead of logging them * fix(service/header): fix lifecylces issues and make listener more minimal * fix(service/header): core listener should stop if at least one error happens * log(service/header): make annoying 'validation error' a warning
Wondertan
previously approved these changes
Jan 9, 2022
adlerjohn
reviewed
Jan 9, 2022
liamsi
approved these changes
Jan 10, 2022
Wondertan
approved these changes
Jan 10, 2022
Bidon15
pushed a commit
to Bidon15/celestia-node
that referenced
this pull request
Jan 11, 2022
…casting new `ExtendedHeader`s to the gossipsub network (celestiaorg#327) * core listener * set ctx and cancelfunc to nil after stopped service * changelog * changelog remove todod * feat(core): add GetBlockInfo to Fetcher (#3) feat(service/header): make a helper to assemble ExtendedHeaders refactor(service/header): make core exchange to rely on new helpers refactor(service/header): make core listener to rely on new helpers refactor(node/core): rework construction of core exchange refactor(service): remove erasure as redudandant chore: lint * chore: lint * Broadcaster code review + an alternative (#4) * fix(core): wrap errors instead of logging them * fix(service/header): fix lifecylces issues and make listener more minimal * fix(service/header): core listener should stop if at least one error happens * log(service/header): make annoying 'validation error' a warning * use commit height in GetBlockInfo Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the last component necessary for bridge nodes to be able to listen to core nodes for new block events and translate them to
ExtendedHeaders.A more comprehensive explanation can be found here.
Resolves second TODO in #251.
Resolves #214