Skip to content

Commit

Permalink
changelog
Browse files Browse the repository at this point in the history
remove todod
  • Loading branch information
renaynay committed Jan 7, 2022
1 parent fb2a04c commit 76672fb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 7 additions & 1 deletion service/header/core_listener.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,13 @@ import (
"github.com/tendermint/tendermint/types"
)

// CoreListener TODO @renaynay: document
// CoreListener is responsible for listening to Core for
// new block events and converting new Core blocks into
// the main data structure used in the Celestia DA network:
// `ExtendedHeader`. After digesting the Core block, extending
// it, and generating the `ExtendedHeader`, the CoreListener
// broadcasts the new `ExtendedHeader` to the header-sub gossipsub
// network.
type CoreListener struct {
ex *CoreExchange
p2pSub *P2PSubscriber
Expand Down
4 changes: 0 additions & 4 deletions service/header/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ type Service struct {
p2pServer *P2PExchangeServer
}

// TODO @renaynay: how will we register core listener on the header Service? It's a part of header service but
// we can't pass it directly to constructor b/c only Bridge nodes provide CoreListener, otherwise it'll always be nil
// maybe we can make it an interface? Still hacky.

// NewHeaderService creates a new instance of header Service.
func NewHeaderService(
syncer *Syncer,
Expand Down

0 comments on commit 76672fb

Please sign in to comment.