service/header: Refactor broadcaster to only be used within HeaderService when core (bridge mode) is enabled
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
force-pushed
the
refactor-broadcaster
branch
from
ef74c90 to
7cbec6e
Compare
renaynay
force-pushed
the
refactor-broadcaster
branch
from
6ea68ea to
26ffa1b
Compare
|
@adlerjohn this PR needs mega rebasing onto #317 after that's merged. I'll probably end up closing this PR anyway after integrating some of the changes. |
|
Closing in favour of #327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the last component necessary for bridge nodes to be able to listen to core nodes for new block events and translate them to
ExtendedHeaders.A more comprehensive explanation can be found here.
Resolves second TODO in #251.