Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/header: change Broadcaster from interface to struct #214

Closed
Wondertan opened this issue Nov 18, 2021 · 3 comments · Fixed by #327
Closed

service/header: change Broadcaster from interface to struct #214

Wondertan opened this issue Nov 18, 2021 · 3 comments · Fixed by #327
Assignees
@renaynay
Labels
area:header Extended header

Comments

@Wondertan
Copy link
Member

No description provided.

@renaynay
Copy link
Member

Now that BlockService is only responsible for reconstructing block from shares and HeaderService is responsible for constructing new ExtendedHeaders and broadcasting them, broadcaster doesn't need an interface and can be a private struct instead.

@renaynay renaynay changed the title service/header: remove Broadcaster and don't expose pubsub.Topic on Subscriber service/header: change Broadcaster from interface to struct Nov 29, 2021
@renaynay renaynay added the area:header Extended header label Nov 29, 2021
@renaynay renaynay self-assigned this Nov 29, 2021
@renaynay renaynay mentioned this issue Nov 29, 2021
Closed
2 tasks
@liamsi liamsi moved this to In Progress in Celestia Node Dec 7, 2021
@renaynay renaynay moved this from In Progress to In Review in Celestia Node Dec 24, 2021
@renaynay renaynay moved this from In Review to In Progress in Celestia Node Jan 3, 2022
@Wondertan
Copy link
Member Author

@renaynay should we close this one already?

@renaynay
Copy link
Member

renaynay commented Jan 7, 2022

Not until #327 is merged.

@renaynay renaynay mentioned this issue Jan 7, 2022
Merged
@renaynay renaynay moved this from In Progress to In Review in Celestia Node Jan 7, 2022
Repository owner moved this from In Review to Done in Celestia Node Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renaynay renaynay

Labels
area:header Extended header
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
2 participants
@Wondertan @renaynay