Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Font rendering for web fonts is too light #126

Open
blueboxd opened this issue Dec 24, 2022 · 6 comments
Open

[BUG] Font rendering for web fonts is too light #126

blueboxd opened this issue Dec 24, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@blueboxd
Copy link
Owner

Describe the bug
On websites which use web fonts, the fonts are rendering at a much lighter weight than how the mainline version of Chromium renders fonts. This is only web fonts - system fonts, when featured on a site, are unaffected by this bug.

To Reproduce

  1. For a site which demonstrates this, go to https://sonosaurus.com/paulxstretch/changes.html
  2. This example site uses Montserrat from Google Fonts for all body text
  3. Take a screenshot of how the site renders in Chromium Legacy 1084385.
  4. Next load the site using v100 of Chromium built from the mainline source code, e.g. this version here https://github.com/macchrome/macstable/releases/tag/v100.0.4896.75-r972766-Ungoogled-macOS
  5. Notice that the font text is much thinner on Chromium Legacy compared to how it renders on the mainline Chromium original

Expected behavior
The fonts should render in an identical fashion, regardless of if the site uses a system font (i.e. Lucida Grande) or if the site is using a web font (i.e Montserrat from Google Fonts).

Screenshots
Chromium Legacy rendering of Montserrat:
correct

Chromium original rendering of Montserrat:
bug

Desktop (please complete the following information):

  • OS: El Capitan
  • Build 1084385
@blueboxd blueboxd added the bug Something isn't working label Dec 24, 2022
@blueboxd
Copy link
Owner Author

@dotclean @Wowfunhappy Sorry, original issue (#125) unexpectedly vanished...why???

@blueboxd
Copy link
Owner Author

blueboxd commented Dec 24, 2022 •
edited
Loading

We need to investigate these commits.

  • 1032258 renders without issue
    • 'skia_revision': 'e8674a8843e228a0a8b8cbc7d0c453f226a734d7'
  • 1036413 has this issue
    • 'skia_revision': '4b720a135d0d755bb901e2397b971a48df56694d'

and, once displayed (created cache?) with 1032258-, 1036413+ render same fonts without problem.
(delete ~/Library/Caches/Chromium to replicate again)

blueboxd pushed a commit that referenced this issue Feb 8, 2023
Allow PrefetchService to block until the head of a prefetch is received
68bad88 
when trying to serve the prefetch.

This CL allows for a prefetch that has been started but waiting on the
head of the response to be served. In this case, PrefetchService will
block until the head of the prefetch is received, then pass it to
PrefetchURLLoaderInterceptor it is servable.

(cherry picked from commit 2e83b5d)

Bug: 1375852
Change-Id: I32a99bfae3fe739020ad1b5313c0a1a8b6c6a82a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4121433
Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org>
Commit-Queue: Max Curran <curranmax@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1087624}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4134704
Auto-Submit: Max Curran <curranmax@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5481@{#126}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
@michaeldo1
[M111] Add feature flag for preventing navigation
1dfa550 
This new logic was added in crrev.com/c/4206652. Adding a new flag to be
used as a killswitch in case there are any unintended side effects of
this change which are not observed before stable.

(cherry picked from commit 7ab182a)

Bug: 1408799
Change-Id: I22110d7c4a5f1f839c9cb0dd3725e5a854947d5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4215894
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1100500}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4218202
Commit-Queue: Ali Juma <ajuma@chromium.org>
Auto-Submit: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/branch-heads/5563@{#126}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
Roll Amd64 AFDO from 112.0.5615.9_rc-r1-merged to 112.0.5615.12_rc-r1…
53408b7 
…-merged

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I47063bcac0a419cb22604fbd461f9942d87144b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4302670
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{#126}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
[Merge M113] Handle NPE for layoutManager when closing last tab
5026d75 
(cherry picked from commit 5fc6dc3)

Bug: 1428099
Change-Id: I269c384da4003da6d62a1b533eabb09a7827d4c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4377340
Commit-Queue: Sirisha Kavuluru <skavuluru@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1123228}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4382380
Cr-Commit-Position: refs/branch-heads/5672@{#126}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
[Password Manager] Fix console errors related to checkup list item
61b6d66 
This CL fixes an error when group was used before checking it for
undefined.

(cherry picked from commit 8729382)

Bug: 1440042
Change-Id: Id6c2d437204f494d779336cedd9fb1810c538f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481257
Auto-Submit: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1136503}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489825
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/branch-heads/5735@{#126}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
blueboxd pushed a commit that referenced this issue Sep 10, 2023
Quick Delete: UI fixes
49cf850 
Update the dialog UX to fit the UX proposal.

Before: https://screenshot.googleplex.com/AECTkMJNpV8RqFQ
Screenshot (light): https://screenshot.googleplex.com/8BMn46TrFHuiLWg
Screenshot (dark): https://screenshot.googleplex.com/ASmnBnjDmJrLTue

(cherry picked from commit 9f06842)

Bug: 1412087, b/294173198
Change-Id: I2b2f454ad5407768da5f355d98dc918d5d90f981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4767479
Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Zaina Al-Mashni <zalmashni@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1182505}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4778425
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Auto-Submit: Zaina Al-Mashni <zalmashni@google.com>
Reviewed-by: Sinan Sahin <sinansahin@google.com>
Cr-Commit-Position: refs/branch-heads/5938@{#126}
Cr-Branched-From: 2b50cb4-refs/heads/main@{#1181205}
blueboxd pushed a commit that referenced this issue Nov 6, 2023
[3pcd] Add UMA histogram for profile/client eligibility mismatch
b62be1b 
(cherry picked from commit 1eaf2a0)

Bug: 1489403
Change-Id: I379cb6ea846fd68b87156d8f9b08478aaf266bee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4911717
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Anton Maliev <amaliev@chromium.org>
Commit-Queue: Patricia Alfonso <trishalfonso@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1205835}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4916698
Cr-Commit-Position: refs/branch-heads/6045@{#126}
Cr-Branched-From: 905e8bd-refs/heads/main@{#1204232}
@donluca donluca mentioned this issue Nov 8, 2023
Closed
@donluca
Copy link

donluca commented Nov 10, 2023

As of 119.0.6045.105.1, this bug is still present.

@donluca
Copy link

donluca commented Dec 10, 2023

Still present on 120.0.6099.71.1

@gpsvisualizer
Copy link

Fonts are still too light in v123.

@Flopper1p
Copy link

Still present. I can only use older versions on 10.8.5 because of this :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gpsvisualizer @blueboxd @donluca @Flopper1p