[Password Manager] Fix console errors related to checkup list item

This CL fixes an error when group was used before checking it for
undefined.

(cherry picked from commit 8729382)

Bug: 1440042
Change-Id: Id6c2d437204f494d779336cedd9fb1810c538f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4481257
Auto-Submit: Viktor Semeniuk <vsemeniuk@google.com>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1136503}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489825
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/branch-heads/5735@{#126}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}

Author: Viktor Semeniuk

chrome/browser/resources/password_manager/checkup_list_item.html

@@ -66,12 +66,12 @@
 </style>
 <div id="separator" class="hr" hidden="[[first]]"></div>
 <div id="list-item" focus-row-container>
-  <site-favicon url="[[group.iconUrl]]" domain="[[group.name]]"
+  <site-favicon url="[[getGroupIcon_(group)]]" domain="[[getGroupName_(group)]]"
       aria-hidden="true">
   </site-favicon>
   <div id="credentialInfo">
     <div id="shownUrl" class="label text-elide">
-      [[group.name]]
+      [[getGroupName_(group)]]
     </div>
     <div id="usernameContainer" class="cr-secondary-text label">
       <span id="username" class="text-elide">[[item.username]]</span>
@@ -113,7 +113,7 @@
 <template is="dom-if" if="[[showEditPasswordDisclaimer_]]" restamp>
   <edit-password-disclaimer-dialog
       on-edit-password-click="onEditPasswordClick_"
-      origin="[[group.name]]"
+      origin="[[getGroupName_(group)]]"
       on-close="onEditDisclaimerClosed_">
   </edit-password-disclaimer-dialog>
 </template>
@@ -125,7 +125,7 @@
 <template is="dom-if" if="[[showDeletePasswordDialog_]]" restamp>
   <delete-password-disclaimer-dialog id="deletePasswordDialog"
       on-delete-password-click="onDeletePasswordClick_"
-      on-close="onDeletePasswordDialogClosed_" origin="[[group.name]]"
+      on-close="onDeletePasswordDialogClosed_" origin="[[getGroupName_(group)]]"
       action-url="[[item.changePasswordUrl]]">
   </delete-password-disclaimer-dialog>
 </template>

chrome/browser/resources/password_manager/checkup_list_item.ts

@@ -186,12 +186,20 @@ export class CheckupListItemElement extends CheckupListItemElementBase {
     }));
   }
 
+  private getGroupName_(): string {
+    return !this.group ? '' : this.group.name;
+  }
+
+  private getGroupIcon_(): string {
+    return !this.group ? '' : this.group.iconUrl;
+  }
+
   private getChangeButtonAriaLabel_(): string {
-    return this.i18n('changePasswordAriaDescription', this.group.name);
+    return this.i18n('changePasswordAriaDescription', this.getGroupName_());
   }
 
   private getMoreButtonAriaLabel_(): string {
-    return this.i18n('moreActionsAriaDescription', this.group.name);
+    return this.i18n('moreActionsAriaDescription', this.getGroupName_());
   }
 }