Skip to content

Commit 9c6408e

Browse files
christhompsonChromium LUCI CQ
authored and
Chromium LUCI CQ
committed
[HTTPS-First Mode] Enable HFMv2 by default
Enables the HttpsFirstModeV2 feature flag by default now that the new version matches the V1 implementation. Also explicitly disables HFMv2 in the V1 test suite (https_only_mode_browsertest.cc) to maintian coverage for V1 for now. Bug: 1394910 Change-Id: Ic690640e760d53d1e793bbb4559ee091dfa98d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4288115 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Chris Thompson <cthomp@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1109224}
1 parent 6c22e41 commit 9c6408e

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

chrome/browser/ssl/https_only_mode_browsertest.cc

+3-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,9 @@ class HttpsOnlyModeBrowserTest : public InProcessBrowserTest {
5454
~HttpsOnlyModeBrowserTest() override = default;
5555

5656
void SetUp() override {
57-
feature_list_.InitAndEnableFeature(features::kHttpsOnlyMode);
57+
feature_list_.InitWithFeatures(
58+
/*enabled_features=*/{features::kHttpsOnlyMode},
59+
/*disabled_features=*/{features::kHttpsFirstModeV2});
5860
InProcessBrowserTest::SetUp();
5961
}
6062

chrome/common/chrome_features.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -618,7 +618,7 @@ BASE_FEATURE(kHttpsFirstModeForAdvancedProtectionUsers,
618618
// Enables the new implementation of HTTPS-First Mode.
619619
BASE_FEATURE(kHttpsFirstModeV2,
620620
"HttpsFirstModeV2",
621-
base::FEATURE_DISABLED_BY_DEFAULT);
621+
base::FEATURE_ENABLED_BY_DEFAULT);
622622

623623
// Enables automatically upgrading main frame navigations to HTTPS.
624624
BASE_FEATURE(kHttpsUpgrades,

0 commit comments

Comments
 (0)