Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Destination connections from UI #16310

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Hide Destination connections from UI #16310

merged 1 commit into from
Sep 2, 2022

Conversation

ryankfu
Copy link
Contributor

@ryankfu ryankfu commented Sep 2, 2022

What

Hiding Cassandra Destination until these issues are fixed:

Hiding Databricks Destination until these issues are fixed:

Hiding DynamoDB Destination until these issues are fixed:

Hiding GCS Destination until these issues are fixed:

Hiding Kafka Destination until these issues are fixed:

Hiding MariaDB Destination until these issues are fixed:

Hiding MongoDB Destination until these issues are fixed:

Hiding MQTT Destination until these issues are fixed:

Hiding Pulsar Destination until these issues are fixed:

Hiding Rockset Destination until these issues are fixed:

Hiding S3 Destination until these issues are fixed:

Hiding Scylla Destination until these issues are fixed:

How

Describe the solution
Uses the same filtering method as #16276 to hide connections from Cloud

Recommended reading order

  1. constants.ts

🚨 User Impact 🚨

Existing connections will continue to work, the only change will be that this hides the connections from being created which gives a little breathing room to address these. Priority for resolution would be MongoDB and S3 as those are the only non-zero connections used in Cloud

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

@ryankfu ryankfu requested a review from a team as a code owner September 2, 2022 20:50
@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Sep 2, 2022
@ryankfu ryankfu merged commit 82ceb8a into master Sep 2, 2022
@ryankfu ryankfu deleted the ryan/hide-insecure-connections branch September 2, 2022 21:04
letiescanciano added a commit that referenced this pull request Sep 5, 2022
@letiescanciano
Merge branch 'master' into leti/fix-page-tracking-in-segment
f4afffe 
* master: (47 commits)
  Add email to identify users analytics call (#16327)
  🎉 Source Amazon Ads: improve `config.start_date` validation (#16191)
  Add comments about intermediate state emission (#16262)
  MySQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16216)
  MSSQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16215)
  Hide a bunch more destination with potential unsecure API access (#16320)
  Skip unit tests when run-tests is false (#16267)
  Hide Destination connections from UI (#16310)
  Add scheduled task to clean up old files from workspace (#16247)
  Source Google Analytics v4: Re-name google analytics connector (#16306)
  🐛 Source Facebook Marketing: remove "end_date" from config if empty value (re-implement #16096) (#16222)
  Fix github action syntax (#16277)
  Re-name google analytics cionnectors (#16287)
  Bump Airbyte version from 0.40.3 to 0.40.4 (#16275)
  Hide ES and Redis destination connectors from Cloud (#16276)
  15700  add tests for PokeAPI (#15701)
  Add ProtocolVersion to StandardDefs (#16237)
  🪟 🔧 🧹 Migrate attempt `bytesSynced` to `totalStats.bytesEmitted` and cleanup `AttemptDetails` component (#16126)
  Improve behavior of password input field (#16011)
  Improve airbyte-metrics support in the Helm chart (#16166)
  ...
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Sep 12, 2022
Merged
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
@ryankfu @robbinhan
Hide Destination connections from UI (airbytehq#16310)
09cb252
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
@ryankfu @jhammarstedt
Hide Destination connections from UI (airbytehq#16310)
343d04c
@grishick grishick added the team/destinations Destinations team's backlog label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodireich rodireich rodireich approved these changes

@bleonard bleonard Awaiting requested review from bleonard

@grishick grishick Awaiting requested review from grishick

@sherifnada sherifnada Awaiting requested review from sherifnada

@cgardens cgardens Awaiting requested review from cgardens

Assignees
No one assigned
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform team/destinations Destinations team's backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryankfu @rodireich @grishick