15700 add tests for PokeAPI #15701
Merged
15700 add tests for PokeAPI #15701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ambirdsall
reviewed
Aug 30, 2022
There was a problem hiding this comment.
I left a number of smaller comments about edits for certain lines of code and a vaguer long-term suggestion for organizing the files; but overall, I'm totally fine with the changes in here. Once the suggested changes are in place and there's a passing CI run, I'll be happy to approve this PR. Good work so far!
airbyte-webapp-e2e-tests/cypress/integration/onboarding.spec.ts
Outdated
Show resolved
Hide resolved
| import { createTestSource } from "./source"; | ||
| import { createLocalJsonDestination } from "./destination"; | ||
| import { createPokeTestSource, createPostgresSource } from "./source"; | ||
| import { openAddSource } from "pages/destinationPage" |
There was a problem hiding this comment.
The most common pattern for a cypress/commands/ directory is to create general-purpose utilities for interacting with a specific app: shortcuts for logging in as a given user, selecting an element by a conventional selector (like our use of data-testid attributes), or working with more complicated UI elements like dropdowns are all standard examples.
I have no serious problem with the code as you've written it, but I do think that pattern is a very useful way to work with Cypress tests; in the long run, I'd recommend reorganizing things a little bit, so that the utilities in pages/ import utilities from files in commands/ but the utilities in commands/ don't import from files in pages/.
airbyte-webapp-e2e-tests/cypress/integration/connection.spec.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
added
area/connectors
octavia-squidington-iii
added
connectors/destination/redshift
connectors/destination/s3
connectors/destination/tidb
connectors/source/sentry
connectors/source/facebook-marketing
connectors/source/amplitude
connectors/source/plaid
connectors/source/mysql
connectors/source/pinterest
connectors/source/postgres
connectors/source/redshift
labels
add body verification
SofiiaZaitseva
force-pushed
the
Sofiia_UpdateConnection_ExtendE2ETests
branch
from
4c9ccbc to
2428bf8
Compare
github-actions
bot
removed
normalization
area/documentation
fix request url and schedule dropdown value
ambirdsall
approved these changes
Sep 2, 2022
letiescanciano
added a commit
that referenced
this pull request
Sep 5, 2022
* master: (47 commits) Add email to identify users analytics call (#16327) 🎉 Source Amazon Ads: improve `config.start_date` validation (#16191) Add comments about intermediate state emission (#16262) MySQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16216) MSSQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16215) Hide a bunch more destination with potential unsecure API access (#16320) Skip unit tests when run-tests is false (#16267) Hide Destination connections from UI (#16310) Add scheduled task to clean up old files from workspace (#16247) Source Google Analytics v4: Re-name google analytics connector (#16306) 🐛 Source Facebook Marketing: remove "end_date" from config if empty value (re-implement #16096) (#16222) Fix github action syntax (#16277) Re-name google analytics cionnectors (#16287) Bump Airbyte version from 0.40.3 to 0.40.4 (#16275) Hide ES and Redis destination connectors from Cloud (#16276) 15700 add tests for PokeAPI (#15701) Add ProtocolVersion to StandardDefs (#16237) 🪟 🔧 🧹 Migrate attempt `bytesSynced` to `totalStats.bytesEmitted` and cleanup `AttemptDetails` component (#16126) Improve behavior of password input field (#16011) Improve airbyte-metrics support in the Helm chart (#16166) ...
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* add tests for PokeAPI * Update connection.spec.ts add body verification * add page object model for update connection (poke api) test * change structure with using POM * Select sync mode dropdown with a data-testid (airbytehq#16053) * Fix coments * fix goToDestinationPage signature * move fillEmail method * change structure with using POM * Fix coments * Update connection.spec.ts fix request url and schedule dropdown value Co-authored-by: Alex Birdsall <ambirdsall@gmail.com>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* add tests for PokeAPI * Update connection.spec.ts add body verification * add page object model for update connection (poke api) test * change structure with using POM * Select sync mode dropdown with a data-testid (airbytehq#16053) * Fix coments * fix goToDestinationPage signature * move fillEmail method * change structure with using POM * Fix coments * Update connection.spec.ts fix request url and schedule dropdown value Co-authored-by: Alex Birdsall <ambirdsall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.