Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to enforce SSL in MongoDB Source connector #16278

Closed
2 tasks
ryankfu opened this issue Sep 2, 2022 · 5 comments · Fixed by #17590
Closed
2 tasks

Add ability to enforce SSL in MongoDB Source connector #16278

ryankfu opened this issue Sep 2, 2022 · 5 comments · Fixed by #17590
Assignees
Labels
needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request

Comments

@ryankfu
Copy link
Contributor

ryankfu commented Sep 2, 2022

Tell us about the problem you're trying to solve

  • MongoDB does not always enforce SSL
  • we need a test that validates this behavior
  • we need an explanation in the docs about why customers cannot set ssl/tls=false in Airbyte Cloud

Describe the solution you’d like

Implement configuration for adding ssl parameter for MongoDB source

Describe the alternative you’ve considered or used

A clear and concise description of any alternative solutions or features you've considered or are using today.

Additional context

Connection Options

Are you willing to submit a PR?

Remove this with your answer :-)

@grishick
Copy link
Contributor

Mongo URL has ssl and tls options and we need to check that these parameters are not overwritten in -strict-encrypt version of MongoDB source

@grishick
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @akashkulk @edgao @ryankfu @subodh1810 @tuliren

@tuliren
Copy link
Contributor

tuliren commented Sep 14, 2022

  • Should also update the documentation to explain about the final implementation.

@tuliren
Copy link
Contributor

tuliren commented Sep 14, 2022

From Subodh, the tls parameter is ignored for ATLAS and REPLICA SET. Need to make sure we don't override it.

@grishick grishick added the team/db-dw-sources Backlog for Database and Data Warehouse Sources team label Sep 27, 2022
@subodh1810
Copy link
Contributor

@akashkulk wanted to take this up and since I have not yet started working on it, I am re-assigning this to him.
cc @grishick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants