Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to enforce SSL in S3 Destination connector #16301

Closed
ryankfu opened this issue Sep 2, 2022 · 5 comments · Fixed by #17340
Closed

Add ability to enforce SSL in S3 Destination connector #16301

ryankfu opened this issue Sep 2, 2022 · 5 comments · Fixed by #17340
Assignees
Labels
needs-triage team/destinations Destinations team's backlog type/enhancement New feature or request

Comments

@ryankfu
Copy link
Contributor

ryankfu commented Sep 2, 2022

Tell us about the problem you're trying to solve

S3 does not always enforce SSL

Describe the solution you’d like

Implement configuration for adding ssl parameter for S3 destination

Describe the alternative you’ve considered or used

A clear and concise description of any alternative solutions or features you've considered or are using today.

Additional context

S3 bucket policy ssl-requests-only

Are you willing to submit a PR?

Remove this with your answer :-)

@grishick
Copy link
Contributor

grishick commented Sep 6, 2022

Note from backlog grooming: rather than creating a new strict-encrypt connector for S3 destination, we can use the environment variable (see PostgresSourceStrictEncrypt for the example.

Scope of this ticket (definition of done):

  • update the documentation to recommend that users set bucket policies that enforce TLS (see AWS docs)
  • configure S3 client to always use TLS
  • check that custom endpoint (if one is passed) uses HTTPS in check method

@grishick
Copy link
Contributor

grishick commented Sep 6, 2022

Hey team! Please add your planning poker estimate with Zenhub @edgao @rodireich @ryankfu @subodh1810 @tuliren

@grishick
Copy link
Contributor

grishick commented Sep 6, 2022

@grishick
Copy link
Contributor

grishick commented Sep 7, 2022

Based on this doc, all access to S3 on AWS is with TLS: https://docs.aws.amazon.com/AmazonS3/latest/userguide/network-isolation.html

@ryankfu ryankfu self-assigned this Sep 8, 2022
@grishick grishick added the team/destinations Destinations team's backlog label Sep 27, 2022
@grishick
Copy link
Contributor

Reading the JavaDoc for S3 client it appears it is configured to use HTTPS by default already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage team/destinations Destinations team's backlog type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants