-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Add release notes v1.35.0 #22137
[doc] Add release notes v1.35.0 #22137
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel-bin/tools/release_engineering/relnotes --action=create --version=v1.35.0 --prior_version=v1.34.0
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel-bin/tools/release_engineering/relnotes --action=update --version=v1.35.0
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
doc/_release-notes/v1.35.0.md
line 4 at r1 (raw file):
title: Drake v1.35.0 date: 2099-12-31 released: YYYY-MM-DD
Set to Working. Remind myself to update the date when it's ready.
Code quote:
date: 2099-12-31
released: YYYY-MM-DD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 54 at r2 (raw file):
* Fix `GraphOfConvexSets` when passing in a trivially-infeasible upper bound ([#22090][_#22090]) ## Multibody Dynamics and Geometry
Multibody Dynamics and Geometry
is next. Working.
- Multibody Dynamics and Geometry - Miscellaneous features and fixes - pydrake bindings - Build system - Removal of deprecated items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 136 at r3 (raw file):
* [fix] TBD [workspace] Upgrade rules_rust to latest release 0.53.0 ([#22119][_#22119]) * [fix] TBD [workspace] Upgrade abseil_cpp_internal to latest commit ([#22118][_#22118]) * TBD
Next is "Build dependencies."
Code quote:
* [fix] TBD [workspace] Force-disable CoinUtils debugging hooks ([#22063][_#22063])
* [fix] TBD [workspace] Upgrade openusd_internal to latest release 24.11 ([#22082][_#22082])
* [fix] TBD [workspace] Upgrade drake_models to latest commit ([#22103][_#22103])
* [fix] TBD [workspace] Upgrade crate_universe to latest ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade dm_control_internal to latest release 1.0.24 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade msgpack_internal to latest release cpp-7.0.0 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade mujoco_menagerie_internal to latest commit ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade mypy_internal to latest release v1.13.0 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade statsjs to latest commit ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade suitesparse_internal to latest release v7.8.3 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade tinyobjloader_internal to latest commit ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade vtk_internal to latest commit ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade rules_rust to latest release 0.53.0 ([#22119][_#22119])
* [fix] TBD [workspace] Upgrade abseil_cpp_internal to latest commit ([#22118][_#22118])
* TBD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 136 at r3 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
Next is "Build dependencies."
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
-- commits
line 30 at r5:
I'm ready to do --action=update
again and merge upstream/master without rebase.
Code quote:
New commits in r5 on 11/12/2024 at 5:44 PM:
- 73b8c5e: Sort "Build system", "Build dependencies", "Removal of deprecated items"
- e90c69c: Fix typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
Previously, DamrongGuoy (Damrong Guoy) wrote…
I'm ready to do
--action=update
again and merge upstream/master without rebase.
Done.
- Mathematical Program - Multibody Dynamics and Geometry - Planning - Miscellaneous features and fixes - pydrake bindings - Build dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
doc/_release-notes/v1.35.0.md
line 4 at r1 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
Set to Working. Remind myself to update the date when it's ready.
We're on November 12 now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-(status: do not review)
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2.
Reviewable status: 5 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
doc/_release-notes/v1.35.0.md
line 62 at r8 (raw file):
BTW I almost wonder if this didn't get the wrong tag. Technically, it expands public API (which is why it got the "feature" tag). However, explaining what that feature is is difficult.
Let's try this phrase:
Allow GeometryInstance to be registered through MultibodyPlant with clarifications on the related semantics
doc/_release-notes/v1.35.0.md
line 9 at r8 (raw file):
# Announcements * TBD
Also, don't forget to update these TBDs "None" before the final version.
doc/_release-notes/v1.35.0.md
line 118 at r8 (raw file):
<!-- <relnotes for cmake,doc,setup,third_party,tools go here> --> * Upgrade bazelisk to latest release v1.22.1 ([#22119][_#22119])
nit: In alphabetical order, bazelisk
would come after bazel
doc/_release-notes/v1.35.0.md
line 118 at r8 (raw file):
<!-- <relnotes for cmake,doc,setup,third_party,tools go here> --> * Upgrade bazelisk to latest release v1.22.1 ([#22119][_#22119])
nit: These "upgrade to latest..." lines all belong under the next block: "Build dependencies".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 4 at r1 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
We're on November 12 now.
We're at 6:30 PM PST, November 13, now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 54 at r12 (raw file):
* Parallelize `ComputePairwiseIntersections()` for Graph of Convex Sets (with or without continuous revolute joints) ([#22142][_#22142]) * Retrieve dual solution for `LinearMatrixInequalityConstraint` for Mosek ([#22144][_#22144]) * Parallelize the `GraphOfConvexSets` preprocessing stage ([#21965][_#21965])
@hongkai-dai @cohnt The commit messages of these two PRs arrived today (Wednesday). I polished them a bit.
Code quote:
* Retrieve dual solution for `LinearMatrixInequalityConstraint` for Mosek ([#22144][_#22144])
* Parallelize the `GraphOfConvexSets` preprocessing stage ([#21965][_#21965])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 4 at r1 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
We're at 6:30 PM PST, November 13, now.
Last night, there was one more PR ((commit: 3613367)) merged into master before the Nightly started.
I'll run relnotes --action=update --version=v1.35.0 --target_commit=3613367
and cut the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the Nightly passed except linux-jammy-gcc-bazel-nightly-coverage/409/ with a coverage timeout in one unit test. We can still release v1.35.0 today.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
doc/_release-notes/v1.35.0.md
line 97 at r8 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
Done. Thank you! I hope this is good now. Please let me know if we should change it more.
May I please say something about commit messages? Now I can see the title of PR 22099 was
SliceByTime for PiecewisePolynomials
; however, the merged commit 2a39984 into master wasTrim PiecewisePolynomials (#22099)
. The commit message was the one that got pulled into the release notes automatically.When a PR is near ready for merging into master, we might want to
rebase squash
the 12 commits into one commit with the appropriate message for release notes. I hope this is useful to know. It's just my two cents.
Right. I changed the function name per reviewer suggestion but didn't update the message. My bad.
bazel-bin/tools/release_engineering/relnotes --action=update --version=v1.35.0 \ --target_commit=36133672b4e2ba86e89157828a80207abe488234
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 4 at r1 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
Last night, there was one more PR ((commit: 3613367)) merged into master before the Nightly started.
I'll run
relnotes --action=update --version=v1.35.0 --target_commit=3613367
and cut the release.
Actually, I had to use the 40-character SHA1.
bazel-bin/tools/release_engineering/relnotes --action=update --version=v1.35.0 --target_commit=36133672b4e2ba86e89157828a80207abe488234
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
-- commits
line 75 at r13:
The PR #22132 of this --target_commit
requests no release notes. The only change to the release notes is the commit number.
Code quote:
bazel-bin/tools/release_engineering/relnotes --action=update --version=v1.35.0 \
--target_commit=36133672b4e2ba86e89157828a80207abe488234
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 97 at r8 (raw file):
Previously, sadraddini (Sadra Sadraddini) wrote…
Right. I changed the function name per reviewer suggestion but didn't update the message. My bad.
Thank you for your explanation. All is well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel run //tools/release_engineering:download_release_candidate -- --find-git-sha 20241114
Done on my Puget.
Reviewable status: 3 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have started the staging builds (Linux Wheel, macOS arm Wheel, Jammy Packaging, Noble Packaging, macOS arm Packaging).
I'll try to finish the release notes now.
Reviewable status: 4 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
a discussion (no related file):
Make sure to wait for the five staging builds to finish before merging. Set to Working.
This reverts commit c1f13a1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did git revert c1f13a1
to enable CI.
Reviewable status: 3 unresolved discussions, needs platform reviewer assigned, needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Officially assign reviewers so that I can merge this PR. +@sherm1 +@hongkai-dai
Reviewable status: 3 unresolved discussions, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 unresolved discussions, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
doc/_release-notes/v1.35.0.md
line 4 at r1 (raw file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
Actually, I had to use the 40-character SHA1.
bazel-bin/tools/release_engineering/relnotes --action=update --version=v1.35.0 --target_commit=36133672b4e2ba86e89157828a80207abe488234
Done.
Previously the @drake-jenkins-bot mac-arm-sonoma-clang-bazel-experimental-release please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
a discussion (no related file):
Previously, DamrongGuoy (Damrong Guoy) wrote…
Make sure to wait for the five staging builds to finish before merging. Set to Working.
Done. The five staging builds have finished successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bazel run //tools/release_engineering:download_release_candidate -- --version v1.35.0
It was done on my Puget. Ready to merge this PR.
Reviewable status: commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @DamrongGuoy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+(status: squashing now)
Reviewable status:
complete! all discussions resolved, LGTM from assignees sherm1(platform),hongkai-dai
It's merged now. Thank you very much, everybody! |
This change is