Release/v1.0.0 #60

PhyXTGears-1720 · 2019-03-04T17:26:49Z

No description provided.

* Add comment for wheel encoder pin clarification. * Add PDP variable (for Shuffleboard use). * Change CAN Bus IDs to ones that the TalonSRX's are set up with. * Change team number to use PhyxtGear's real team number rather than the testing number. * Disable gyro. ** It's unused and is causing error messages on the Compbot (Competition Robot) because it has no ADXRS450 gyro. STATUS: Compiles and deploys on both Protobot and Compbot. NOTES: Make sure that any RoboRIO this code is deployed to has the CTR-E Phoenix Library/Diagnostic tools installed, and that VS Code has the CTR-E Phoenix vendor library installed. - Logan H-D

* Reverse each side's TalonSRX's. * Switch to Arcade Drive. * Switch back to Protobot to continue testing later. STATUS: Compiles, deploys, and runs on both Protobot and Compbot. - Logan H-D

* The PDP on Protobot doesn't have a CAN Bus to communicate with, which causes timeout errors during runtime. STATUS: Compiles, deploys, and runs on Protobot. - Logan H-D

* Create subsystem and associated functions and members for the Creeper Arm. * Add associated pin numbers and CAN IDs. * Edit some grammar. STATUS: Builds and deploys on Protobot, untested on Compbot - Logan H-D

STATUS: Builds and deploys to Protobot, untested on Compbot. - Logan H-D

* Add notice for wiring spreadsheet. * Change from AnalogInput to Analog Potentiometer ** This will need to be checked later. * Reformat RobotMap.h - Logan H-D

STATUS: Builds. Untested on Probot and Compbot. - Justin C for Logan H-D

- Use proximity sensor to detect cargo and finish TakeCargo command. - If cargo already taken, command loop will still activate motors for one iteration of Execute() before detecting cargo. Might add check for cargo in Execute(). - Proximity sensor reports false when nearby object is detected. - Found problem using JoystickButton objects. Joystick not detected in OI::OI(). STATUS: Builds and deploys to Protobot, untested on Compbot. - Justin C

This name is more informative than GetRotation() and matches name in header file. Maybe GetArmRotation()? I wouldn't mind GetArmRotationDegrees or GetArmRotationRadians. - Justin C

For consistency. - Justin C

STATUS: Builds. Deployed to protobot. Untested on Compbot. - Justin C

Merging branch 'feature/stub-subsystems' into develop - Robby S for Justin C and Logan H-D

Robot will take cargo from the dispenser or from the floor. Split TakeCargo into two commands for each location. The other choice is to break up the CargoIntake subsystem so rollers are controlled separately from the CargoIntake rotation. STATUS: Builds. Untested on Protobot or Compbot. - Justin C

STATUS: Builds. Not tested. - Justin C

TODO: Command starts rollers and detects cargo. Finish implementing command. STATUS: Builds. Not Tested. - Justin C

TODO: Command does nothing. Implement command. STATUS: Builds. Not tested. - Justin C

The text for the example of spacing in function definitions, declarations, and calls, still showed the previous style even though the example was updated. The description now matches the example.

Only affects files that don't have a copyright preamble. First uses BSD license, so let's do the same. STATUS: Builds. - Justin C Signed-off-by: PhyXTGears <phyxtgearspro@gmail.com>

STATUS: Builds - Justin C Signed-off-by: PhyXTGears <phyxtgearspro@gmail.com>

Fix text for in CODESTYLE.md

…erage Add class to compute running average

Add BSD license and PhyXTGears copyright

STATUS: Just comments and indentation changed. - Logan H-D

* Add GrabHatchFromDispenser. * Add ReleaseHatch. * Add appropriate constants for cargo-intake. * Add test code in TeleOp mode. ** Press A to grab, press B to release. * Stub RotateHatchForDispenser and RotateHatchForFloor. * Change indentation in some header files. * Disable Creeper Arm stuff temporarily (solenoids causing issues). STATUS: Builds and deploys, works as intended on CompBot. - Logan H-D

- Logan H-D

Commented code is no longer necessary now that the boolean flag only permits one run. STATUS: Builds. - Justin C

Intake as recalibrated from scratch during 2019-03-02 testing, which includes resetting the zero-point to zero. STATUS: Builds. Tested on testbot. - Robby S, Logan H-D, Justin C

Feature/house keeping

STATUS: Builds. - Justin C

STATUS: Builds. Tested on testbot. - Justin C

STATUS: Builds. - Justin C

STATUS: Builds. Tested on testbot. - Justin C

Attempts to lock the piston between extents consistently fails. Instead, increase creeper arm climb position to keep robot level during climb. STATUS: Builds. Tested on testbot. - Justin C

Rename SandstormPlatformDrive to DriveSandstormStepWithHatch. During testing we couldn't stop from dropping the hatch, so we're replacing the hatch with cargo. Keeping this command around in case we figure out how to hold onto the hatch during landing. STATUS: Builds. - Justin C

Since we can't drive sandstorm with dropping the hatch, let's drive with cargo. STATUS: Builds. Tested on testbot 2019-03-04. - Justin C

Use makefile to deploy with a version file, so the software announces to the drive tream which release we're running with. TODO: Print version.txt during RobotInit, maybe even DisableInit. STATUS: Builds. - Justin C

…19-03-04 Feature/testing 2019 03 04

STATUS: Builds. Tested on testbot 2019-03-05. - Justin C

Tried to clear existing commands out of the scheduler when robot is disabled, so commands don't resume when entering teleop or autonomous. Unfortunately, the default command for the DriveTrain subsystem died, and our robot was bereft. Return to running scheduler in DisablePeriodic to at least clear out cancelled commands. STATUS: Builds. Tested on testbot 2019-03-05. - Justin C

Driver can use right bumper to toggle cameras. Operator can use button 11 (whatever that is) on the flightstick to toggle cameras. STATUS: Builds. Tested on testbot 2019-03-05. - Justin C

STATUS: Builds. - Justin C

…19-03-05 Feature/testing 2019 03 05

Wait until after Mishiwaka competition to fix.

Tuning for St. Joeseph event Tested - Robby S

Add IsRollerRunning so the rollers can be stopped manually after ground pickup Enable drive during climb Slow down creeper arm from 0.65 to 0.6 (untested) Tested (mostly) - Robby S

boxofrox · 2019-03-13T00:16:55Z

src/main/cpp/Robot.cpp

@@ -23,7 +25,6 @@ RotateHatchForDispenser*        Robot::m_RotateHatchForDispenser;

 ShootCargoForCargoShip*         Robot::m_ShootCargoForCargoShip;
 ShootCargoForLevelOneRocket*    Robot::m_ShootCargoForLevelOneRocket;
-ShootCargoForLevelTwoRocket*    Robot::m_ShootCargoForLevelTwoRocket;


ShootCargoForLevelTwoRocket should not be removed. A later commit will add this back in from competition/adjustments, so review is approved anyways.

PhyXTGears-1720 and others added 30 commits January 31, 2019 19:42

Adjust driving.

99fc1d2

* Reverse each side's TalonSRX's. * Switch to Arcade Drive. * Switch back to Protobot to continue testing later. STATUS: Compiles, deploys, and runs on both Protobot and Compbot. - Logan H-D

Prevent PDP from being used on Protobot.

72f576d

* The PDP on Protobot doesn't have a CAN Bus to communicate with, which causes timeout errors during runtime. STATUS: Compiles, deploys, and runs on Protobot. - Logan H-D

Add Creeper Arm subsystem.

fce7a90

* Create subsystem and associated functions and members for the Creeper Arm. * Add associated pin numbers and CAN IDs. * Edit some grammar. STATUS: Builds and deploys on Protobot, untested on Compbot - Logan H-D

Properly add Creeper Arm to the robot.

dcb73ee

STATUS: Builds and deploys to Protobot, untested on Compbot. - Logan H-D

More Creeper Arm work.

e9063d6

* Add notice for wiring spreadsheet. * Change from AnalogInput to Analog Potentiometer ** This will need to be checked later. * Reformat RobotMap.h - Logan H-D

Add cargo intake subsystem

13d7384

STATUS: Builds. Untested on Probot and Compbot. - Justin C for Logan H-D

Fix typo: CreeperArm::GetArmAngle()

93e1114

This name is more informative than GetRotation() and matches name in header file. Maybe GetArmRotation()? I wouldn't mind GetArmRotationDegrees or GetArmRotationRadians. - Justin C

Reformat variable names.

b617d2f

For consistency. - Justin C

Add macros to distinguish roborio port assignments in RobotMap

308dde6

STATUS: Builds. Deployed to protobot. Untested on Compbot. - Justin C

Add subsystem stubs

b4b0e09

Merging branch 'feature/stub-subsystems' into develop - Robby S for Justin C and Logan H-D

Document goal and command sequence for TakeCargoFromDispenser

c267859

STATUS: Builds. Not tested. - Justin C

Add command TakeCargoFromFloor

73b0764

TODO: Command starts rollers and detects cargo. Finish implementing command. STATUS: Builds. Not Tested. - Justin C

Add command RotateCargoForLevelOneRocket

50e0e48

TODO: Command does nothing. Implement command. STATUS: Builds. Not tested. - Justin C

Add command RotateCargoForLevelTwoRocket

6d8e29e

TODO: Command does nothing. Implement command. STATUS: Builds. Not tested. - Justin C

Add command RotateCargoForCargoShip

b83df5c

TODO: Command does nothing. Implement command. STATUS: Builds. Not tested. - Justin C

Add command ShootCargoForCargoShip

290f9c1

TODO: Command does nothing. Implement command. STATUS: Builds. Not tested. - Justin C

Add command ShootCargoForLevelOneRocket

29b484c

TODO: Command does nothing. Implement command. STATUS: Builds. Not tested. - Justin C

Add command ShootCargoForLevelTwoRocket

05f2497

TODO: Command does nothing. Implement command. STATUS: Builds. Not tested. - Justin C

Fix text for in CODESTYLE.md

7707e55

The text for the example of spacing in function definitions, declarations, and calls, still showed the previous style even though the example was updated. The description now matches the example.

Add BSD license and PhyXTGears copyright

92cc0ee

Only affects files that don't have a copyright preamble. First uses BSD license, so let's do the same. STATUS: Builds. - Justin C Signed-off-by: PhyXTGears <phyxtgearspro@gmail.com>

Add class to compute running average

0a10e16

STATUS: Builds - Justin C Signed-off-by: PhyXTGears <phyxtgearspro@gmail.com>

Merge pull request #9 from PhyXTGears-programming/feature/fix-codestyle

cd0626d

Fix text for in CODESTYLE.md

Merge pull request #10 from PhyXTGears-programming/feature/running-av…

082b09a

…erage Add class to compute running average

Merge pull request #11 from PhyXTGears-programming/feature/license

5a205bc

Add BSD license and PhyXTGears copyright

Fix indentation and remove copyright notice.

e416959

STATUS: Just comments and indentation changed. - Logan H-D

Use full 180 degrees with Dispenser Hatch Grab.

a3b7a22

- Logan H-D

boxofrox added 18 commits March 4, 2019 17:16

Remove useless code.

3adb764

Commented code is no longer necessary now that the boolean flag only permits one run. STATUS: Builds. - Justin C

Reset zero point for intake on testbot.

bff86b2

Intake as recalibrated from scratch during 2019-03-02 testing, which includes resetting the zero-point to zero. STATUS: Builds. Tested on testbot. - Robby S, Logan H-D, Justin C

Merge pull request #61 from PhyXTGears-programming/feature/house-keeping

cab9e75

Feature/house keeping

Clear commands out of scheduler when disabled.

1325669

STATUS: Builds. - Justin C

Require operator to hold buttons to move cheesecake hatch.

047abad

STATUS: Builds. Tested on testbot. - Justin C

Use std:: prefix for cout/endl print debugging.

477013f

STATUS: Builds. - Justin C

Disable piston when resetting CreeperClimb.

06ae765

STATUS: Builds. - Justin C

Reduce cargo-ship roller speed to 80%.

767f61b

STATUS: Builds. Tested on testbot. - Justin C

Increase creeper arm climb position.

9149234

Attempts to lock the piston between extents consistently fails. Instead, increase creeper arm climb position to keep robot level during climb. STATUS: Builds. Tested on testbot. - Justin C

Add command DriveSandstormStepWithCargo.

ad08819

Since we can't drive sandstorm with dropping the hatch, let's drive with cargo. STATUS: Builds. Tested on testbot 2019-03-04. - Justin C

Add Makefile.

8615c0e

Use makefile to deploy with a version file, so the software announces to the drive tream which release we're running with. TODO: Print version.txt during RobotInit, maybe even DisableInit. STATUS: Builds. - Justin C

Merge pull request #62 from PhyXTGears-programming/feature/testing-20…

593cc68

…19-03-04 Feature/testing 2019 03 04

Implement command ShootCargoForLevelTwoRocket.

e7d77a0

STATUS: Builds. Tested on testbot 2019-03-05. - Justin C

Add camera switching to drive tream controls.

c201de6

Driver can use right bumper to toggle cameras. Operator can use button 11 (whatever that is) on the flightstick to toggle cameras. STATUS: Builds. Tested on testbot 2019-03-05. - Justin C

Remove comments and consolidate copyrights.

af6e77c

STATUS: Builds. - Justin C

Merge pull request #63 from PhyXTGears-programming/feature/testing-20…

db03e54

…19-03-05 Feature/testing 2019 03 05

PhyXTGears-1720 requested a review from rsammelson March 8, 2019 04:16

boxofrox previously approved these changes Mar 8, 2019

View reviewed changes

PhyXTGears-1720 added 2 commits March 8, 2019 21:32

Tune variable for compbot

47d296d

Tuning for St. Joeseph event Tested - Robby S

Final Code for Friday Night

306ee11

Add IsRollerRunning so the rollers can be stopped manually after ground pickup Enable drive during climb Slow down creeper arm from 0.65 to 0.6 (untested) Tested (mostly) - Robby S

PhyXTGears-1720 dismissed boxofrox’s stale review via 306ee11 March 12, 2019 21:52

rsammelson approved these changes Mar 13, 2019

View reviewed changes

boxofrox approved these changes Mar 13, 2019

View reviewed changes

NotQuiteApex approved these changes Mar 13, 2019

View reviewed changes

boxofrox reviewed Mar 13, 2019

View reviewed changes

boxofrox merged commit e836439 into master Mar 13, 2019

rsammelson deleted the release/v1.0.0 branch March 13, 2019 00:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release/v1.0.0 #60

Release/v1.0.0 #60

PhyXTGears-1720 commented Mar 4, 2019

boxofrox Mar 13, 2019

Release/v1.0.0 #60

Release/v1.0.0 #60

Conversation

PhyXTGears-1720 commented Mar 4, 2019

boxofrox Mar 13, 2019

Choose a reason for hiding this comment