feat: setup improve for testing #6187

Lanttcat · 2022-04-29T08:31:03Z

feat: split wallet app entries
chore: type
chore: type
feat: user guide
chore: solve conflict
Revert "chore: solve conflict"
chore: solve conflict
feat: should open twitter when user click agree button on welcome page
feat: be opened social network should determined by the caller
feat: merge develop
feat: recommend feature app
chore: update event
chore: persona connect
fix: little fix
fix: dialog title text center
fix: style
chore: add comment
fix: ui style
chore: ui style

Description

Closes #MF-415 #MF-416

Type of change

Documentation
Code refactoring (Restructuring existing code w/o changing its observable behavior)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

My code follows the style guidelines of this project.
I have performed a self-review of my own code.
- I have removed all in development console.logs
- I have removed all commented code.
I have commented on my code, particularly in hard-to-understand areas.
I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

I have configured those APIs with CORS headers to let extension requests get passed.
- chrome extension: chrome-extension://[id]
- firefox extension: moz-extension://[id]
I have delegated all web requests to the background service via the internal RPC bridge.

This reverts commit a6a0438.

…-guide * hancheng/split-application-wallet-entry: (63 commits) chore: ui style fix: ui style chore: add comment fix: style fix: dialog title text center feat: add new theme color (#6094) refactor: move queryPersonaByProfile refactor: rename a field fix: little fix chore: persona connect chore: cleanup usage of toText chore: better type of signWithPersona refactor: post db types (#6172) fix: import make styles path in theme package (#6174) [Release] New release 2.7.0 (minor) (#6142) chore: update event chore(eslint): prefer object-shorthand (#6171) feat: recommend feature app fix: typo (#6173) refactor: xdai features EIP1559 (#6170) ...

…for-testing

github-actions · 2022-04-29T08:36:07Z

🚀 Deployed on https://627f658dd597503caf657751--compassionate-northcutt-326a3a.netlify.app

packages/shared/src/contexts/components/InjectedDialog.tsx

Jack-Works · 2022-05-09T06:30:58Z

packages/mask/src/social-network/ui.ts

@@ -226,6 +228,19 @@ export async function activateSocialNetworkUIInner(ui_deferred: SocialNetworkUI.
    }
 }

+export async function loadSocialNetworkUIs(): Promise<SocialNetworkUI.Definition[]> {


Why you're going to load every SNS Adaptors?

We need to have the user authorize all SNS before creating persona.

packages/mask/src/components/InjectedComponents/ToolboxUnstyled.tsx

packages/dashboard/src/pages/Welcome/hooks/useSetupSocialNetwork.ts

Jack-Works

change request

packages/shared/src/contexts/components/InjectedDialog.tsx

packages/dashboard/src/pages/Welcome/index.tsx

Jack-Works · 2022-05-10T02:54:39Z

packages/mask/src/social-network/ui.ts

@@ -86,8 +86,10 @@ export async function activateSocialNetworkUIInner(ui_deferred: SocialNetworkUI.
    ui.collecting.currentVisitingIdentityProvider?.start(signal)

    ui.injection.pageInspector?.(signal)
-    if (Flags.toolbox_enabled) ui.injection.toolbox?.(signal)
-    ui.injection.setupPrompt?.(signal)
+    if (Flags.toolbox_enabled) {


Looks like this PR contains many code from #6114. I'll defer the review.

packages/mask/src/extension/background-script/SocialNetworkService.ts

packages/dashboard/src/pages/Welcome/index.tsx

Co-authored-by: septs <github@septs.pw>

This reverts commit 8f4c1aa.

septs · 2022-05-14T07:51:01Z

packages/mask/src/extension/background-script/SocialNetworkService.ts

    return requestExtensionPermission({
-        origins: [...req.map((x) => x.declarativePermissions.origins).flat()],
+        origins: [...uis.map((x) => x.declarativePermissions.origins).flat()],


Suggested change

origins: [...uis.map((x) => x.declarativePermissions.origins).flat()],

origins: uis.map((x) => x.declarativePermissions.origins).flat(),

packages/mask/src/components/GuideStep/index.tsx

Jack-Works · 2022-05-15T03:10:12Z

packages/dashboard/src/pages/Welcome/index.tsx

@@ -79,7 +77,10 @@ export default function Welcome() {
            iframeRef={iframeRef}
            privacyPolicyURL={agreementContentPageURL}
            iframeLoadHandler={handleIFrameLoad}
-            agreeHandler={() => navigate(DashboardRoutes.Setup)}
+            agreeHandler={async () => {
+                const url = await Services.SocialNetwork.setupSocialNetwork('twitter.com', false)


Why do you set up Twitter by default?

* develop: (124 commits) chore: improve string operations readability (#6257) fix: lint disable (#6238) chore: improve keyboard event (#6251) chore: simplify tutorial link (#6253) fix: remove useless style (#6252) docs(i18n): sync i18n files from Crowdin (#6254) refactor: the connect wallet dialog (#6218) fix(xdai): temporally disable 1559 feature, since failing of gas estimation (#6245) fix: limit for create persona (#6247) fix: add linked persona identifier to profile information (#6234) feat: setup improve for testing (#6187) New translations en-US.json (Quenya) (#6249) fix: backup not restore correctly (#6229) fix: check next id verified (#6242) fix: popup steps show snackbar issues (#6243) fix: adjust layout of dialog title (#6225) refactor: generate contact avatar color (#6239) fix: not parse mask payload (#6237) feat: update twitter theme color (#6236) chore: no-nested-ternary on plugins (#6223) ...

zhouhanseng and others added 26 commits April 20, 2022 19:34

feat: split wallet app entries

00f65f9

chore: type

4957651

chore: type

9653259

Merge branch 'develop' into hancheng/split-application-wallet-entry

a724a45

feat: user guide

993a4e1

chore: solve conflict

a6a0438

Revert "chore: solve conflict"

3f84e7e

This reverts commit a6a0438.

Merge branch 'develop' into hancheng/split-application-wallet-entry

68358ed

chore: solve conflict

d6f5ed4

feat: should open twitter when user click agree button on welcome page

5bf451e

feat: be opened social network should determined by the caller

912ea48

feat: merge develop

0366282

feat: recommend feature app

c66d357

chore: update event

dd64f52

Merge branch 'develop' into hancheng/split-application-wallet-entry

1dfe7e9

chore: persona connect

dc84ea1

fix: little fix

086d846

Merge branch 'develop' into hancheng/split-application-wallet-entry

b2d96dd

fix: dialog title text center

df51ff4

fix: style

6dd82ca

chore: add comment

7fd0bdd

fix: ui style

caea3be

chore: ui style

321f852

Merge branch 'feat-user-guide' into feat/setup-improve-for-testing

1d7751d

Merge branch 'feat/dashboard-setup-optimize' into feat/setup-improve-…

70533a9

…for-testing

github-actions bot temporarily deployed to pull request April 29, 2022 08:36 Inactive

guanbinrui changed the title ~~feat/setup improve for testing~~ feat: setup improve for testing Apr 29, 2022

guanbinrui reviewed Apr 29, 2022

View reviewed changes

packages/shared/src/contexts/components/InjectedDialog.tsx Outdated Show resolved Hide resolved

Jack-Works reviewed May 9, 2022

View reviewed changes

packages/mask/src/components/InjectedComponents/ToolboxUnstyled.tsx Outdated Show resolved Hide resolved

Jack-Works reviewed May 10, 2022

View reviewed changes

packages/dashboard/src/pages/Welcome/hooks/useSetupSocialNetwork.ts Outdated Show resolved Hide resolved

Jack-Works requested changes May 10, 2022

View reviewed changes

Merge branch 'develop' into feat/setup-improve-for-testing

33d87fe

github-actions bot temporarily deployed to pull request May 11, 2022 04:02 Inactive

feat: setup social network in current window

b9e02ad

septs reviewed May 13, 2022

View reviewed changes

packages/dashboard/src/pages/Welcome/index.tsx Outdated Show resolved Hide resolved

github-actions bot temporarily deployed to pull request May 13, 2022 06:12 Inactive

yanzhihong23 and others added 2 commits May 13, 2022 14:13

chore: remove useSetupSocialNetwork hook

1da164b

chore: reply review

4e70de3

Co-authored-by: septs <github@septs.pw>

github-actions bot temporarily deployed to pull request May 13, 2022 06:20 Inactive

feat: disable open composition dialog after user guide

8f4c1aa

github-actions bot temporarily deployed to pull request May 13, 2022 08:23 Inactive

Revert "feat: disable open composition dialog after user guide"

26bb154

This reverts commit 8f4c1aa.

github-actions bot temporarily deployed to pull request May 14, 2022 04:11 Inactive

feat: code review feedback

bd1a0a5

github-actions bot temporarily deployed to pull request May 14, 2022 07:08 Inactive

septs reviewed May 14, 2022

View reviewed changes

refactor: remove unnecessary array deconstruction

6b32288

github-actions bot temporarily deployed to pull request May 14, 2022 08:00 Inactive

guanbinrui reviewed May 14, 2022

View reviewed changes

packages/mask/src/components/GuideStep/index.tsx Outdated Show resolved Hide resolved

refactor: use location assign to replace direction assignment

e4a2fdd

guanbinrui approved these changes May 14, 2022

View reviewed changes

github-actions bot temporarily deployed to pull request May 14, 2022 08:17 Inactive

yanzhihong23 approved these changes May 14, 2022

View reviewed changes

guanbinrui merged commit f28db25 into develop May 14, 2022

guanbinrui deleted the feat/setup-improve-for-testing branch May 14, 2022 08:39

Jack-Works reviewed May 15, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: setup improve for testing #6187

feat: setup improve for testing #6187

Lanttcat commented Apr 29, 2022 •

edited

Loading

github-actions bot commented Apr 29, 2022 •

edited

Loading

Jack-Works May 9, 2022

Lanttcat May 14, 2022

Jack-Works left a comment

Jack-Works May 10, 2022

septs May 14, 2022

Jack-Works May 15, 2022

	origins: [...uis.map((x) => x.declarativePermissions.origins).flat()],
	origins: uis.map((x) => x.declarativePermissions.origins).flat(),

feat: setup improve for testing #6187

feat: setup improve for testing #6187

Conversation

Lanttcat commented Apr 29, 2022 • edited Loading

Description

Type of change

Previews

Checklist

github-actions bot commented Apr 29, 2022 • edited Loading

Jack-Works May 9, 2022

Choose a reason for hiding this comment

Lanttcat May 14, 2022

Choose a reason for hiding this comment

Jack-Works left a comment

Choose a reason for hiding this comment

Jack-Works May 10, 2022

Choose a reason for hiding this comment

septs May 14, 2022

Choose a reason for hiding this comment

Jack-Works May 15, 2022

Choose a reason for hiding this comment

Lanttcat commented Apr 29, 2022 •

edited

Loading

github-actions bot commented Apr 29, 2022 •

edited

Loading