refactor: the connect wallet dialog #6218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guanbinrui
force-pushed
the
refactor/connect-wallet-dialog
branch
from
46fa34f to
beb0d87
Compare
zhouhanseng
reviewed
May 9, 2022
| <LoadingIcon style={{ color: '#1C68F3' }} /> | ||
| <Typography variant="caption" color="#A6A9B6"> | ||
| {t('loading')} | ||
| <LoadingIcon style={{ color: props.iconColor ?? '#1C68F3' }} /> |
There was a problem hiding this comment.
theme.palette.public.primary // '#1C68F3'
There was a problem hiding this comment.
@nuanyang233 Can I use it?
There was a problem hiding this comment.
We don't override the theme on the popup right now, so I suggest using the dead code color first.
guanbinrui
force-pushed
the
refactor/connect-wallet-dialog
branch
from
b6e9fdf to
f1a6a96
Compare
Jack-Works
reviewed
May 10, 2022
| <WalletStatusBox isDashboard={props.isDashboard} /> | ||
| {!props.isDashboard && <ApplicationBoard />} | ||
| <WalletStatusBox /> | ||
| {!isDashboardPage() && <ApplicationBoard />} |
There was a problem hiding this comment.
🤔 Should we move this file out of SNSAdaptor folder since it is shared with dashboard?
Jack-Works
previously approved these changes
May 10, 2022
yanzhihong23
added a commit
that referenced
this pull request
May 16, 2022
* develop: (124 commits) chore: improve string operations readability (#6257) fix: lint disable (#6238) chore: improve keyboard event (#6251) chore: simplify tutorial link (#6253) fix: remove useless style (#6252) docs(i18n): sync i18n files from Crowdin (#6254) refactor: the connect wallet dialog (#6218) fix(xdai): temporally disable 1559 feature, since failing of gas estimation (#6245) fix: limit for create persona (#6247) fix: add linked persona identifier to profile information (#6234) feat: setup improve for testing (#6187) New translations en-US.json (Quenya) (#6249) fix: backup not restore correctly (#6229) fix: check next id verified (#6242) fix: popup steps show snackbar issues (#6243) fix: adjust layout of dialog title (#6225) refactor: generate contact avatar color (#6239) fix: not parse mask payload (#6237) feat: update twitter theme color (#6236) chore: no-nested-ternary on plugins (#6223) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes MF-480
Previews
Type of change