Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new theme color #6094

Merged
merged 7 commits into from
Apr 28, 2022
Merged

feat: add new theme color #6094

merged 7 commits into from
Apr 28, 2022

Conversation

nuanyang233
Copy link
Collaborator

Description

Closes #MF-421

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2022

@github-actions github-actions bot temporarily deployed to pull request April 17, 2022 14:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 20, 2022 14:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 21, 2022 02:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 21, 2022 14:29 Inactive
Jack-Works
Jack-Works previously approved these changes Apr 22, 2022
@github-actions github-actions bot temporarily deployed to pull request April 25, 2022 06:59 Inactive
guanbinrui
guanbinrui previously approved these changes Apr 26, 2022
@nuanyang233
Copy link
Collaborator Author

Please hold this pr. I'm changing some button default variant in plugin render.

Jack-Works
Jack-Works previously approved these changes Apr 26, 2022
guanbinrui
guanbinrui previously approved these changes Apr 28, 2022
@github-actions github-actions bot temporarily deployed to pull request April 28, 2022 07:10 Inactive
@guanbinrui guanbinrui merged commit fc32df6 into develop Apr 28, 2022
@guanbinrui guanbinrui deleted the feat/new-theme branch April 28, 2022 07:11
nuanyang233 added a commit that referenced this pull request Apr 29, 2022
yanzhihong23 added a commit that referenced this pull request Apr 29, 2022
…-guide

* hancheng/split-application-wallet-entry: (63 commits)
  chore: ui style
  fix: ui style
  chore: add comment
  fix: style
  fix: dialog title text center
  feat: add new theme color (#6094)
  refactor: move queryPersonaByProfile
  refactor: rename a field
  fix: little fix
  chore: persona connect
  chore: cleanup usage of toText
  chore: better type of signWithPersona
  refactor: post db types (#6172)
  fix: import make styles path in theme package (#6174)
  [Release] New release 2.7.0 (minor) (#6142)
  chore: update event
  chore(eslint): prefer object-shorthand (#6171)
  feat: recommend feature app
  fix: typo (#6173)
  refactor: xdai features EIP1559 (#6170)
  ...
etouyang added a commit to etouyang/Maskbook that referenced this pull request May 5, 2022
* 'develop' of github.com:etouyang/Maskbook: (39 commits)
  chore: upgrade to pnpm7 (DimensionDev#6192)
  fix: security text (DimensionDev#6175)
  chore: improve eslint rules (DimensionDev#6189)
  refactor: remove old persona methods
  refactor: move plugin database
  fix: simple request (DimensionDev#6130)
  refactor: remove deprecated profile type
  refactor: mobile_queryPersonas
  fix(tips): user might never config NextID (DimensionDev#6177)
  feat: add new theme color (DimensionDev#6094)
  refactor: move queryPersonaByProfile
  refactor: rename a field
  chore: cleanup usage of toText
  chore: better type of signWithPersona
  refactor: post db types (DimensionDev#6172)
  fix: import make styles path in theme package (DimensionDev#6174)
  [Release] New release 2.7.0 (minor) (DimensionDev#6142)
  chore(eslint): prefer object-shorthand (DimensionDev#6171)
  fix: typo (DimensionDev#6173)
  refactor: xdai features EIP1559 (DimensionDev#6170)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants