Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: popup steps show snackbar issues #6243

Merged
merged 3 commits into from
May 13, 2022
Merged

fix: popup steps show snackbar issues #6243

merged 3 commits into from
May 13, 2022

Conversation

BillySh1
Copy link
Contributor

Description

Closes #MF-663 #MF-664

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

zhouhanseng
zhouhanseng previously approved these changes May 13, 2022
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2022 •
edited
Loading

🚀 Deployed on https://627e210b6b4e4f42ed0a91df--compassionate-northcutt-326a3a.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 13, 2022 07:54 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2022 09:12 Inactive
@BillySh1 BillySh1 merged commit c6fe063 into develop May 13, 2022
@BillySh1 BillySh1 deleted the fix/popup-step-issues branch May 13, 2022 09:57
yanzhihong23 added a commit that referenced this pull request May 16, 2022
@yanzhihong23
Merge branch 'develop' into fix-savings-ui
d69acb4 
* develop: (124 commits)
  chore: improve string operations readability (#6257)
  fix: lint disable (#6238)
  chore: improve keyboard event (#6251)
  chore: simplify tutorial link (#6253)
  fix: remove useless style (#6252)
  docs(i18n): sync i18n files from Crowdin (#6254)
  refactor: the connect wallet dialog (#6218)
  fix(xdai): temporally disable 1559 feature, since failing of gas estimation (#6245)
  fix: limit for create persona (#6247)
  fix: add linked persona identifier to profile information (#6234)
  feat: setup improve for testing (#6187)
  New translations en-US.json (Quenya) (#6249)
  fix: backup not restore correctly (#6229)
  fix: check next id verified (#6242)
  fix: popup steps show snackbar issues (#6243)
  fix: adjust layout of dialog title (#6225)
  refactor: generate contact avatar color (#6239)
  fix: not parse mask payload (#6237)
  feat: update twitter theme color (#6236)
  chore: no-nested-ternary on plugins (#6223)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UncleBill UncleBill UncleBill approved these changes

@Randolph314 Randolph314 Randolph314 approved these changes

@zhouhanseng zhouhanseng zhouhanseng left review comments

Assignees
No one assigned
Labels
Test: Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@BillySh1 @UncleBill @zhouhanseng @Randolph314 @wenluomask