Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra Sidebar Widgets: improve Image widget for usability. #6013

Merged
merged 2 commits into from
Jan 3, 2017
Merged

Extra Sidebar Widgets: improve Image widget for usability. #6013

merged 2 commits into from
Jan 3, 2017

Conversation

lancewillett
Copy link
Contributor

  1. Provide context for height and width values expected (pixels).
  2. Improve error message for invalid or missing image URL.

Syncs r148073-wpcom and r148074-wpcom

Testing instructions:

  • Enable the Image widget, check the labels for Height and Width (they should say "in pixels").
  • Save the widget without an image URL, and check the Customizer or front-end output for the following error message, only to logged-in authors: "Image missing or invalid URL. Please check the Image widget URL in your widget settings."

@lancewillett lancewillett added [Feature] Extra Sidebar Widgets [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Tested on WP.com labels Dec 29, 2016
@lancewillett lancewillett added the [Status] Needs Review This PR is ready for review. label Dec 30, 2016
dereksmart
dereksmart reviewed Jan 3, 2017
View reviewed changes
modules/widgets/image-widget.php
@@ -103,6 +103,10 @@ public function widget( $args, $instance ) {
</figure>'; // wp_kses_post caption on update
}
echo '<div class="jetpack-image-container">' . do_shortcode( $output ) . '</div>';
} else {
if ( current_user_can('edit_theme_options') ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace in parenths

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 3, 2017
@dereksmart dereksmart added this to the 4.5 milestone Jan 3, 2017
@dereksmart dereksmart merged commit 6a92104 into master Jan 3, 2017
@dereksmart
Copy link
Member

merged to 4.5 1d4752e

@dereksmart dereksmart deleted the update/image-widget branch January 3, 2017 19:28
jeherve added a commit that referenced this pull request Jan 9, 2017
@jeherve
Changelog: add #6013
de0c2bc
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
@jeherve @dereksmart
Changelog: add 4.4.2 release post link.
711efa1 
CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
@jeherve @dereksmart
Changelog: add #5866
10bc6c3 
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934

Bring over 4.4.2 changelog from branch-4.4

@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832

Changelog: add 4.4.2 release post link.

CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095

Readme: add @tyxla to the list of contributors.

Improved changelog for your readability and enjoyment

updated the release date

finalizing the changelog with a few more edits
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dereksmart dereksmart dereksmart left review comments

@eliorivero eliorivero Awaiting requested review from eliorivero

Assignees
No one assigned
Labels
[Feature] Extra Sidebar Widgets [Status] Requires String Changes [Status] Tested on WP.com [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
4 participants
@lancewillett @dereksmart @kraftbj @jeherve