Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom css/4.5 changes #5974

Merged
merged 3 commits into from
Jan 10, 2017
Merged

Custom css/4.5 changes #5974

merged 3 commits into from
Jan 10, 2017

Conversation

samhotchkiss
Copy link
Contributor

No description provided.

@samhotchkiss samhotchkiss added this to the 4.5 milestone Dec 21, 2016
@samhotchkiss samhotchkiss requested a review from zinigor December 21, 2016 16:24
@dereksmart
Copy link
Member

@georgestephanis can you explain the context for this changeset?

@dereksmart dereksmart force-pushed the custom-css/4.5-changes branch from 6ed8228 to 63d364f Compare January 5, 2017 14:55
@georgestephanis
Copy link
Member

So, this pull does two things.

1191c3ad711ed8247289077fdc7ed62ea77afeca updates CodeMirror to their current release -- we were running off an ancient version. It concats the relevant libraries and is self-contained.

These three commits:

0db731a572d623b04bdcb4a87b6db4d93b4befe2
7d2b9da29ec074a65cdd22d3927d1d98ec14ca37
63d364f5af1794beb0ce2af7c599ab9b3e26958e

build out some of our legacy Custom CSS behavior by letting WordPress link to the stylesheet for better caching across pages, rather than embedding it directly in the dom every time -- but only if the length of the css is over 2,000 characters. Below that, it's tiny enough that the additional HTTP request probably isn't worthwhile.

@georgestephanis @dereksmart
Handle printing Custom CSS for long custom stylesheets.
46af7fa 
If someone has a massive stylesheet pasted into Custom CSS, it probably
should be embedded via a `<link>` tag, instead of just dumped on the
page.
@georgestephanis @dereksmart
Add a cachebuster and long expiration.
99a53a0
@georgestephanis @dereksmart
Stop using rest api for not rest stuff.
14874e8
@dereksmart dereksmart force-pushed the custom-css/4.5-changes branch from 63d364f to 14874e8 Compare January 9, 2017 18:11
@dereksmart
Copy link
Member

Updated the branch to remove the update to codemirror, as we were experiencing some problems in testing.

Things are working great for me now & this tests well.

@zinigor could you please give it a last review?

zinigor
zinigor approved these changes Jan 10, 2017
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works well. One thing that we may want to do in the future is to use etags to determine if we need to actually send the response. That would let us reduce stylesheet waiting time even more.

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jan 10, 2017
@dereksmart dereksmart merged commit 1ce0288 into master Jan 10, 2017
@dereksmart
Copy link
Member

Merged to 4.5 fc8be3f

@dereksmart dereksmart deleted the custom-css/4.5-changes branch January 10, 2017 13:30
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
@jeherve @dereksmart
Changelog: add 4.4.2 release post link.
711efa1 
CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
@jeherve @dereksmart
Changelog: add #5866
10bc6c3 
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934

Bring over 4.4.2 changelog from branch-4.4

@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832

Changelog: add 4.4.2 release post link.

CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095

Readme: add @tyxla to the list of contributors.

Improved changelog for your readability and enjoyment

updated the release date

finalizing the changelog with a few more edits
@jeherve jeherve mentioned this pull request Feb 13, 2017
Closed
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinigor zinigor zinigor approved these changes

Assignees
No one assigned
Labels
[Feature] Custom CSS [Pri] BLOCKER
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
7 participants
@samhotchkiss @dereksmart @georgestephanis @zinigor @kraftbj @jeherve @matticbot