Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Protect for OVH #5866

Merged
merged 5 commits into from
Dec 13, 2016
Merged

Fix Protect for OVH #5866

merged 5 commits into from
Dec 13, 2016

Conversation

dereksmart
Copy link
Member

Deactivate Protect and show an admin notice if we can't get an IP address, which can be caused by a misconfigured server.

To test the UX with a fine IP:

  • Activate Protect
  • force jetpack_protect_get_ip() to return false
  • Log out/log back in. When you visit your Jetpack admin, you should see a notice and Protect should be deactivated.
  • Try to activate protect. It should fail, and on page reload it will tell you why.

@dereksmart dereksmart added [Feature] Protect Also known as Brute Force Attack Protection [Status] Needs Review This PR is ready for review. labels Dec 13, 2016
@dereksmart dereksmart added this to the 4.5 milestone Dec 13, 2016
@samhotchkiss samhotchkiss self-requested a review December 13, 2016 21:51
@samhotchkiss
Copy link
Contributor

Ship it!

@dereksmart dereksmart merged commit 1e24826 into master Dec 13, 2016
@dereksmart dereksmart removed the [Status] Needs Review This PR is ready for review. label Dec 13, 2016
@dereksmart dereksmart deleted the fix/protect-for-ovh branch December 13, 2016 22:20
jeherve added a commit that referenced this pull request Dec 21, 2016
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934

Bring over 4.4.2 changelog from branch-4.4

@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832

Changelog: add 4.4.2 release post link.

CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095

Readme: add @tyxla to the list of contributors.

Improved changelog for your readability and enjoyment

updated the release date

finalizing the changelog with a few more edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Protect Also known as Brute Force Attack Protection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants