Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading Holiday Snow in Footer Instead of Head #5931

Merged
merged 1 commit into from
Dec 16, 2016

Conversation

BFTrick
Copy link
Contributor

@BFTrick BFTrick commented Dec 16, 2016

Fixes #5930

Loading the holiday snow feature in the footer. Better for page load speed.
@jeherve jeherve added [Feature] Theme Tools [Pri] Low [Status] Needs Review This PR is ready for review. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Dec 16, 2016
@jeherve jeherve added this to the 4.5 milestone Dec 16, 2016
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair, and works well. LGTM. 🚢

@jeherve jeherve added [Status] Needs Changelog [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Dec 16, 2016
@eliorivero eliorivero merged commit 39ef9cf into Automattic:master Dec 16, 2016
@eliorivero
Copy link
Contributor

Thanks @BFTrick!

@dereksmart
Copy link
Member

merged to branch-4.5 82d2af4

happy holidays @BFTrick !

@BFTrick BFTrick deleted the patch-1 branch December 16, 2016 20:23
@BFTrick
Copy link
Contributor Author

BFTrick commented Dec 16, 2016

@dereksmart Thanks!

Any eta on 4.5?

@dereksmart
Copy link
Member

dereksmart commented Dec 16, 2016

@BFTrick looking to be around mid-January (holidays and such), so I'd go ahead and apply this to your sites manually since the snow is going to stop before then anyway :)

jeherve added a commit that referenced this pull request Dec 21, 2016
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934
dereksmart pushed a commit that referenced this pull request Jan 17, 2017
Changelog: add #5867

Changelog: add #5874

Changelog: add #5905

Changelog: add #5906

Changelog: add #5931

Changelog: add #5933

Changelog: add #5934

Bring over 4.4.2 changelog from branch-4.4

@see 18012a3

Changelog: add #5976, #5978, #5983

Changelog: add #5917

Changelog: add #5832

Changelog: add 4.4.2 release post link.

CHangelog: add #5457

Changelog: add #5487

Changelog: add #5708

Changelog: add #5879

Changelog: add #5932

Changelog: add #5963

Changelog: add #5968

Changelog: add #5996

Changelog: add #5998

Changelog: add #5999

Changelog: add #6012

Changelog: add #6013

Changelog: add #6014

Changelog: add #6015

Changelog: add #6023

Changelog: add #6024

Changelog: add #6030

Changelog: add #5465

CHangelog: add #6063

Changelog: add #6025

Changelog: add #5974

Changelog: add #6059

Changelog: add #6046

Changelog: add #5418

Changelog: move things around and add missing information.

Changelog: add #5565

Changelog: add #6087

Changelog: add #6095

Readme: add @tyxla to the list of contributors.

Improved changelog for your readability and enjoyment

updated the release date

finalizing the changelog with a few more edits
@kraftbj kraftbj removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Tools [Pri] Low [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Holiday Snow Loads In Head - Slows Down Page Load
5 participants